Re: [PATCH V12 0/14] Paravirtualized ticket spinlocks

4 messages, 2 authors, 2013-08-09 · open the first message on its own page

Re: [PATCH V12 0/14] Paravirtualized ticket spinlocks

From: "H. Peter Anvin" <hpa@zytor.com>
Date: 2013-08-09 01:06:04

The kbuild test bot is reporting some pretty serious errors for this
patchset.  I think these are serious enough that the patchset will need
to be respun.

	-hpa

Re: [PATCH V12 0/14] Paravirtualized ticket spinlocks

From: Raghavendra K T <hidden>
Date: 2013-08-09 04:22:03

On 08/09/2013 06:34 AM, H. Peter Anvin wrote:
The kbuild test bot is reporting some pretty serious errors for this
patchset.  I think these are serious enough that the patchset will need
to be respun.
I  am working on that.

Re: [PATCH V12 0/14] Paravirtualized ticket spinlocks

From: Raghavendra K T <hidden>
Date: 2013-08-09 13:08:37

On 08/09/2013 06:34 AM, H. Peter Anvin wrote:
The kbuild test bot is reporting some pretty serious errors for this
patchset.  I think these are serious enough that the patchset will need
to be respun.
There were two problems:
(1) we were including spinlock_types.h in arch/x86/include/asm/paravirt_types.h.

This was resulting in redefinition of arch_spinlock_t for non SMP kernel

solution was :
conditional inclusion of spinlock_types.h like below

#ifdef CONFIG_SMP
#include <asm/spinlock_types.h>
#else
typedef u16 __ticket_t;
#endif

(we needed __ticket_t declaration for UP)

(2) we had forward declaration of atomic_read in jumpl_label.
It was causing problem for alpha, which has macro for atomic_read
instead of static inline.

Solution was to remove forward declaration and have atomic.h included.

Peter,
 the above two changes needs small changes in patch 1 and patch 9.
I 'll be resending only those two patches.

I am happy to resend the whole series if it is better and easier for
you.

Re: [PATCH V12 0/14] Paravirtualized ticket spinlocks

From: Raghavendra K T <hidden>
Date: 2013-08-09 14:14:15

On 08/09/2013 06:34 AM, H. Peter Anvin wrote:
The kbuild test bot is reporting some pretty serious errors for this
patchset.  I think these are serious enough that the patchset will need
to be respun.
Sent V13, there were 3 patches in total that changed due to dependency.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help