# Re: \[PATCH 2/2\] Connector: Correctly set the error code in case of success when dispatching receive callbacks

- From: Greg KH \<hidden\>
- Date: 2011-05-17 23:06:31 
- List: virtualization
- Page: https://ratatoskr.run/virtualization/2011/05/3716430
- Thread: https://ratatoskr.run/lkml/2011/05/3716399/t.md

```text
On Tue, May 17, 2011 at 10:53:18PM +0000, KY Srinivasan wrote:
> 
> 
> > -----Original Message-----
> > From: Greg KH [mailto:<redacted>]
> > Sent: Tuesday, May 17, 2011 6:32 PM
> > To: KY Srinivasan
> > Cc: gregkh@suse.de; <redacted>;
> > devel@linuxdriverproject.org; virtualization@lists.osdl.org
> > Subject: Re: [PATCH 2/2] Connector: Correctly set the error code in case of
> > success when dispatching receive callbacks
> > 
> > On Tue, May 17, 2011 at 03:25:38PM -0700, K. Y. Srinivasan wrote:
> > > The recent changes to the connector code introduced this bug where even
> > > when a callback was invoked, we would return an error resulting in
> > > double freeing of the skb. This patch fixes this bug.
> > 
> > By "recent" what do you mean?  Is this something that is in the .39
> > kernel?  Do you have a git commit id that caused this?
> > 
> > Or is this due to changes that are queued up for the .40 merge window?
> 
> I just happened to test KVP functionality yesterday on latest bits from your tree (NEXT)
> and discovered that whenever  something was sent to the kernel from userland on a 
> connector channel, the system would hang. The following commit appears to be where
> this bug was introduced:
> 
> commit 04f482faf50535229a5a5c8d629cf963899f857c
> Author: Patrick McHardy [ref]
> Date:   Mon Mar 28 08:39:36 2011 +0000
> 
> Since prior to this commit I don't see this problem. In any event the current code is clearly
> broken.

Ok, since this was released in the 2.6.39-rc2 kernel, this needs to get
backported to the .39-stable kernel release as well, I'll mark it as
such when I apply it to the tree.

thanks,

greg k-h
```