Thread (3 messages) 3 messages, 2 authors, 2021-03-23

[virtio-comment] Re: [RFC PATCH v2] virtio-vsock: use C style defines for constants

From: Stefan Hajnoczi <stefanha@redhat.com>
Date: 2021-03-23 12:43:57
Also in: virtualization

On Tue, Mar 23, 2021 at 12:04:44PM +0300, Arseny Krasnov wrote:
This:
1) Replaces enums with C style defines.
Why? Please include the rationale for this change in the commit
description.
quoted hunk ↗ jump to hunk
@@ -227,6 +226,11 @@ \subsubsection{Stream Sockets}\label{sec:Device Types / Socket Device / Device O
 hints are permanent once sent and successive packets with bits clear do not
 reset them.
 
+\begin{lstlisting}
+#define VIRTIO_VSOCK_SHUTDOWN_RECEIVE_BIT 0
+#define VIRTIO_VSOCK_SHUTDOWN_SEND_BIT    1
+\end{lstlisting}
Please reference these constants in the text.

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help