[U-Boot] [PATCH v1] mmc: pci: only compile on platforms that need it

From: Felipe Balbi <redacted>

We should only compile pci_mmc.c on platforms that actually need
this. Some platforms are using generic sdhci through driver model.

Signed-off-by: Felipe Balbi <redacted>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/mmc/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/Makefile b/drivers/mmc/Makefile
index 49413dfaf1..26db92e582 100644
--- a/drivers/mmc/Makefile
+++ b/drivers/mmc/Makefile

@@ -36,7 +36,9 @@ obj-$(CONFIG_MVEBU_MMC) += mvebu_mmc.o
 obj-$(CONFIG_MMC_OMAP_HS)		+= omap_hsmmc.o
 obj-$(CONFIG_MMC_MXC)			+= mxcmmc.o
 obj-$(CONFIG_MMC_MXS)			+= mxsmmc.o
-obj-$(CONFIG_X86) += pci_mmc.o
+obj-$(CONFIG_INTEL_BAYTRAIL) += pci_mmc.o
+obj-$(CONFIG_INTEL_QUARK) += pci_mmc.o
+obj-$(CONFIG_INTEL_QUEENSBAY) += pci_mmc.o
 obj-$(CONFIG_PXA_MMC_GENERIC) += pxa_mmc_gen.o
 obj-$(CONFIG_SUPPORT_EMMC_RPMB) += rpmb.o
 obj-$(CONFIG_S3C_SDI) += s3c_sdi.o

-- 
2.11.0

Hi,

On 02/13/2017 11:56 PM, Andy Shevchenko wrote:

How about adding new CONFIG_MMC_X86_PCI for this.

obj-$(CONFIG_MMC_X86_PCI) += pci_mmc.o

Of course, you need to modify Kconfig file.

Best Regards,
Jaehoon Chung

 obj-$(CONFIG_PXA_MMC_GENERIC) += pxa_mmc_gen.o
 obj-$(CONFIG_SUPPORT_EMMC_RPMB) += rpmb.o
 obj-$(CONFIG_S3C_SDI) += s3c_sdi.o

Hi,

Jaehoon Chung [off-list ref] writes:

On 02/13/2017 11:56 PM, Andy Shevchenko wrote:

quoted

From: Felipe Balbi <redacted>

We should only compile pci_mmc.c on platforms that actually need
this. Some platforms are using generic sdhci through driver model.

Signed-off-by: Felipe Balbi <redacted>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/mmc/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/Makefile b/drivers/mmc/Makefile
index 49413dfaf1..26db92e582 100644
--- a/drivers/mmc/Makefile
+++ b/drivers/mmc/Makefile

@@ -36,7 +36,9 @@ obj-$(CONFIG_MVEBU_MMC) += mvebu_mmc.o
 obj-$(CONFIG_MMC_OMAP_HS)		+= omap_hsmmc.o
 obj-$(CONFIG_MMC_MXC)			+= mxcmmc.o
 obj-$(CONFIG_MMC_MXS)			+= mxsmmc.o
-obj-$(CONFIG_X86) += pci_mmc.o
+obj-$(CONFIG_INTEL_BAYTRAIL) += pci_mmc.o
+obj-$(CONFIG_INTEL_QUARK) += pci_mmc.o
+obj-$(CONFIG_INTEL_QUEENSBAY) += pci_mmc.o

How about adding new CONFIG_MMC_X86_PCI for this.

obj-$(CONFIG_MMC_X86_PCI) += pci_mmc.o

Of course, you need to modify Kconfig file.

doable, no problems for me.

-- 
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170215/2dff4c44/attachment.sig>