[U-Boot] [PATCH] imx: MX6DQ{P}/DL:SABRESD Fix bmode eMMC failure

Subsystems: the rest

STALE3916d

3 messages, 3 authors, 2016-01-29 · open the first message on its own page

[U-Boot] [PATCH] imx: MX6DQ{P}/DL:SABRESD Fix bmode eMMC failure

From: Peng Fan <hidden>
Date: 2016-01-29 02:39:11

From: Ye Li <redacted>

The BOOTCFG value used by bmode for SABRESD eMMC boot are actually for SD card.
Fixed the value to correct one.

The issue was fixed in 2014.04 u-boot, but that patch seems missed during porting
to 2015.04.

Signed-off-by: Ye Li <redacted>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
Cc: Stefano Babic <redacted>
Cc: Fabio Estevam <redacted>
---
 board/freescale/mx6sabresd/mx6sabresd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/freescale/mx6sabresd/mx6sabresd.c b/board/freescale/mx6sabresd/mx6sabresd.c
index d20953d..42f89ab 100644
--- a/board/freescale/mx6sabresd/mx6sabresd.c
+++ b/board/freescale/mx6sabresd/mx6sabresd.c
@@ -638,7 +638,7 @@ static const struct boot_mode board_boot_modes[] = {
 	{"sd2",	 MAKE_CFGVAL(0x40, 0x28, 0x00, 0x00)},
 	{"sd3",	 MAKE_CFGVAL(0x40, 0x30, 0x00, 0x00)},
 	/* 8 bit bus width */
-	{"emmc", MAKE_CFGVAL(0x40, 0x38, 0x00, 0x00)},
+	{"emmc", MAKE_CFGVAL(0x60, 0x58, 0x00, 0x00)},
 	{NULL,	 0},
 };
 #endif
-- 
2.6.2

[U-Boot] [PATCH] imx: MX6DQ{P}/DL:SABRESD Fix bmode eMMC failure

From: Fabio Estevam <festevam@gmail.com>
Date: 2016-01-29 09:24:34

Hi Peng,

On Fri, Jan 29, 2016 at 12:39 AM, Peng Fan [off-list ref] wrote:
From: Ye Li <redacted>

The BOOTCFG value used by bmode for SABRESD eMMC boot are actually for SD card.
Fixed the value to correct one.

The issue was fixed in 2014.04 u-boot, but that patch seems missed during porting
to 2015.04.
I would remove this last sentence as it applies to NXP U-boot release, right?

Otherwise the patch looks good.

[U-Boot] [PATCH] imx: MX6DQ{P}/DL:SABRESD Fix bmode eMMC failure

From: Stefano Babic <hidden>
Date: 2016-01-29 09:30:02

On 29/01/2016 03:39, Peng Fan wrote:
quoted hunk
From: Ye Li <redacted>

The BOOTCFG value used by bmode for SABRESD eMMC boot are actually for SD card.
Fixed the value to correct one.

The issue was fixed in 2014.04 u-boot, but that patch seems missed during porting
to 2015.04.

Signed-off-by: Ye Li <redacted>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
Cc: Stefano Babic <redacted>
Cc: Fabio Estevam <redacted>
---
 board/freescale/mx6sabresd/mx6sabresd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/freescale/mx6sabresd/mx6sabresd.c b/board/freescale/mx6sabresd/mx6sabresd.c
index d20953d..42f89ab 100644
--- a/board/freescale/mx6sabresd/mx6sabresd.c
+++ b/board/freescale/mx6sabresd/mx6sabresd.c
@@ -638,7 +638,7 @@ static const struct boot_mode board_boot_modes[] = {
 	{"sd2",	 MAKE_CFGVAL(0x40, 0x28, 0x00, 0x00)},
 	{"sd3",	 MAKE_CFGVAL(0x40, 0x30, 0x00, 0x00)},
 	/* 8 bit bus width */
-	{"emmc", MAKE_CFGVAL(0x40, 0x38, 0x00, 0x00)},
+	{"emmc", MAKE_CFGVAL(0x60, 0x58, 0x00, 0x00)},
 	{NULL,	 0},
 };
 #endif
Reviewed-by: Stefano Babic <redacted>

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help