Re: [PATCH 00/61] treewide: Use IS_ERR_OR_NULL over manual NULL check - refactor
From: Steven Rostedt <rostedt@goodmis.org>
Date: 2026-03-10 14:16:48
Also in:
amd-gfx, bpf, ceph-devel, cocci, dm-devel, dri-devel, gfs2, intel-gfx, intel-wired-lan, kvm, linux-block, linux-bluetooth, linux-btrfs, linux-cifs, linux-clk, linux-ext4, linux-fsdevel, linux-gpio, linux-hyperv, linux-input, linux-iommu, linux-leds, linux-media, linux-mips, linux-mm, linux-modules, linux-nfs, linux-omap, linux-phy, linux-pm, linux-s390, linux-scsi, linux-sctp, linux-security-module, linux-sh, linux-sound, linux-trace-kernel, linux-usb, linux-wireless, lkml, netdev, ntfs3, sched-ext, v9fs
On Tue, 10 Mar 2026 12:48:26 +0100 Philipp Hahn [off-list ref] wrote:
While doing some static code analysis I stumbled over a common pattern, where IS_ERR() is combined with a NULL check. For that there is IS_ERR_OR_NULL(). I've written a Coccinelle patch to find and patch those instances. The patches follow grouped by subsystem.
Honestly, the IS_ERR_OR_NULL() looks worse in a lot of the locations you updated. Just because we have IS_ERR_OR_NULL() doesn't mean we need to go and replace every location that can use it. NAK for any code this touches that I'm responsible for. -- Steve