[PATCH 5.10] malidp: Fix NULL vs IS_ERR() checking
DORMANTno replies
From: Stefan Ghinea <hidden>
Date: 2023-03-07 22:54:04
Subsystem:
arm mali-dp drm driver, drm drivers, drm drivers and misc gpu patches, the rest · Maintainers:
Liviu Dudau, David Airlie, Simona Vetter, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Linus Torvalds
From: Miaoqian Lin <redacted> commit 15342f930ebebcfe36f2415049736a77d7d2e045 upstream The get_sg_table() function does not return NULL. It returns error pointers. Signed-off-by: Miaoqian Lin <redacted> Signed-off-by: Liviu Dudau <liviu.dudau@arm.com> Link: https://lore.kernel.org/dri-devel/20211213072115.18098-1-linmq006@gmail.com/ (local) Signed-off-by: Stefan Ghinea <redacted> --- drivers/gpu/drm/arm/malidp_planes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c
index f1e8bc39b16d..24604b410372 100644
--- a/drivers/gpu/drm/arm/malidp_planes.c
+++ b/drivers/gpu/drm/arm/malidp_planes.c@@ -348,7 +348,7 @@ static bool malidp_check_pages_threshold(struct malidp_plane_state *ms, else sgt = obj->funcs->get_sg_table(obj); - if (!sgt) + if (IS_ERR(sgt)) return false; sgl = sgt->sgl;
--
2.39.1