# \[PATCH AUTOSEL 4.9 3/4\] phonet/pep: refuse to enable an unbound pipe - From: Sasha Levin \ - Date: 2021-12-27 19:08:10 - List: stable - Page: https://ratatoskr.run/stable/2021/12/1619600 - Thread: https://ratatoskr.run/stable/2021/12/1619599/t.md ```text From: Rémi Denis-Courmont [ Upstream commit 75a2f31520095600f650597c0ac41f48b5ba0068 ] This ioctl() implicitly assumed that the socket was already bound to a valid local socket name, i.e. Phonet object. If the socket was not bound, two separate problems would occur: 1) We'd send an pipe enablement request with an invalid source object. 2) Later socket calls could BUG on the socket unexpectedly being connected yet not bound to a valid object. Reported-by: Signed-off-by: Rémi Denis-Courmont Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/phonet/pep.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/phonet/pep.c b/net/phonet/pep.c index f6aa532bcbf64..1e7945df39928 100644 --- a/net/phonet/pep.c +++ b/net/phonet/pep.c @@ -956,6 +956,8 @@ static int pep_ioctl(struct sock *sk, int cmd, unsigned long arg) ret = -EBUSY; else if (sk->sk_state == TCP_ESTABLISHED) ret = -EISCONN; + else if (!pn->pn_sk.sobject) + ret = -EADDRNOTAVAIL; else ret = pep_sock_enable(sk, NULL, 0); release_sock(sk); -- 2.34.1 ```