Thread (7 messages) 7 messages, 3 authors, 2021-09-17

Re: [PATCH 1/1] fpga: dfl: Avoid reads to AFU CSRs during enumeration

From: Moritz Fischer <mdf@kernel.org>
Date: 2021-09-16 22:50:42
Also in: linux-fpga

On Thu, Sep 16, 2021 at 03:34:39PM -0700, Russ Weight wrote:
On 9/16/21 3:24 PM, Moritz Fischer wrote:
quoted
On Thu, Sep 16, 2021 at 02:07:33PM -0700, Russ Weight wrote:
quoted
CSR address space for Accelerator Functional Units (AFU) is not available
during the early Device Feature List (DFL) enumeration. Early access
to this space results in invalid data and port errors. This change adds
a condition to prevent an early read from the AFU CSR space.

Signed-off-by: Russ Weight <redacted>

Fixes: 23bcda750558 ("fpga: dfl: expose feature revision from struct
dfl_device")
Did you mean:

Fixes: 1604986c3e6b ("fpga: dfl: expose feature revision from struct dfl_device")
Oops - I must have been looking at the wrong branch. Yes - you have the
correct commit ID
quoted
And for future please don't line break those, or we'll get yelled at :)
Got it.

Thanks!
- Russ
quoted
I can locally fix it up, no need to resubmit

- Moritz
Applied w/changes to fixes,

- Moritz
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help