+ mm-thp-fix-call-to-mmu_notifier-in-set_pmd_migration_entry-v2.patch added to -mm tree
From: akpm@linux-foundation.org
Date: 2018-10-13 04:47:53
The patch titled
Subject: mm/thp: fix call to mmu_notifier in set_pmd_migration_entry() v2
has been added to the -mm tree. Its filename is
mm-thp-fix-call-to-mmu_notifier-in-set_pmd_migration_entry-v2.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/mm-thp-fix-call-to-mmu_notifier-in-set_pmd_migration_entry-v2.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/mm-thp-fix-call-to-mmu_notifier-in-set_pmd_migration_entry-v2.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Jérôme Glisse <redacted>
Subject: mm/thp: fix call to mmu_notifier in set_pmd_migration_entry() v2
Inside set_pmd_migration_entry() we are holding page table locks and thus
we can not sleep so we can not call invalidate_range_start/end()
So remove call to mmu_notifier_invalidate_range_start/end() because they
are call inside the function calling set_pmd_migration_entry() (see
try_to_unmap_one()).
Link: http://lkml.kernel.org/r/20181012181056.7864-1-jglisse@redhat.com
Signed-off-by: Jérôme Glisse <redacted>
Reported-by: Andrea Arcangeli <redacted>
Reviewed-by: Zi Yan <redacted>
Acked-by: Michal Hocko <mhocko@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Kirill A. Shutemov <redacted>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Anshuman Khandual <redacted>
Cc: Dave Hansen <redacted>
Cc: David Nellans <redacted>
Cc: Ingo Molnar <redacted>
Cc: Mel Gorman <redacted>
Cc: Minchan Kim <minchan@kernel.org>
Cc: Naoya Horiguchi <redacted>
Cc: Thomas Gleixner <redacted>
Cc: Vlastimil Babka <redacted>
Cc: <redacted>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
--- a/mm/huge_memory.c~mm-thp-fix-call-to-mmu_notifier-in-set_pmd_migration_entry-v2
+++ a/mm/huge_memory.c@@ -2885,9 +2885,6 @@ void set_pmd_migration_entry(struct page if (!(pvmw->pmd && !pvmw->pte)) return; - mmu_notifier_invalidate_range_start(mm, address, - address + HPAGE_PMD_SIZE); - flush_cache_range(vma, address, address + HPAGE_PMD_SIZE); pmdval = *pvmw->pmd; pmdp_invalidate(vma, address, pvmw->pmd);
@@ -2900,9 +2897,6 @@ void set_pmd_migration_entry(struct page set_pmd_at(mm, address, pvmw->pmd, pmdswp); page_remove_rmap(page, true); put_page(page); - - mmu_notifier_invalidate_range_end(mm, address, - address + HPAGE_PMD_SIZE); } void remove_migration_pmd(struct page_vma_mapped_walk *pvmw, struct page *new)
_ Patches currently in -mm which might be from jglisse@redhat.com are mm-thp-fix-call-to-mmu_notifier-in-set_pmd_migration_entry-v2.patch