Patch "vfio-pci: use 32-bit comparisons for register address for gcc-4.5" has been added to the 3.18-stable tree
From: <gregkh@linuxfoundation.org>
Date: 2017-08-04 21:37:07
This is a note to let you know that I've just added the patch titled
vfio-pci: use 32-bit comparisons for register address for gcc-4.5
to the 3.18-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
vfio-pci-use-32-bit-comparisons-for-register-address-for-gcc-4.5.patch
and it can be found in the queue-3.18 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let [off-list ref] know about it.
From foo@baz Fri Aug 4 13:41:01 PDT 2017
From: Arnd Bergmann <arnd@arndb.de> Date: Fri, 30 Dec 2016 08:13:47 -0700 Subject: vfio-pci: use 32-bit comparisons for register address for gcc-4.5 From: Arnd Bergmann <arnd@arndb.de> [ Upstream commit 45e869714489431625c569d21fc952428d761476 ] Using ancient compilers (gcc-4.5 or older) on ARM, we get a link failure with the vfio-pci driver: ERROR: "__aeabi_lcmp" [drivers/vfio/pci/vfio-pci.ko] undefined! The reason is that the compiler tries to do a comparison of a 64-bit range. This changes it to convert to a 32-bit number explicitly first, as newer compilers do for themselves. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Alex Williamson <redacted> Signed-off-by: Sasha Levin <redacted> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- drivers/vfio/pci/vfio_pci_rdwr.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
--- a/drivers/vfio/pci/vfio_pci_rdwr.c
+++ b/drivers/vfio/pci/vfio_pci_rdwr.c@@ -190,7 +190,10 @@ ssize_t vfio_pci_vga_rw(struct vfio_pci_ if (!vdev->has_vga) return -EINVAL; - switch (pos) { + if (pos > 0xbfffful) + return -EINVAL; + + switch ((u32)pos) { case 0xa0000 ... 0xbffff: count = min(count, (size_t)(0xc0000 - pos)); iomem = ioremap_nocache(0xa0000, 0xbffff - 0xa0000 + 1);
Patches currently in stable-queue which might be from arnd@arndb.de are queue-3.18/vfio-pci-use-32-bit-comparisons-for-register-address-for-gcc-4.5.patch queue-3.18/drm-vmwgfx-fix-gcc-7.1.1-warning.patch