Patch "net: Use ns_capable_noaudit() when determining net sysctl permissions" has been added to the 4.7-stable tree
From: <gregkh@linuxfoundation.org>
Date: 2016-09-09 13:48:00
This is a note to let you know that I've just added the patch titled
net: Use ns_capable_noaudit() when determining net sysctl permissions
to the 4.7-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
net-use-ns_capable_noaudit-when-determining-net-sysctl-permissions.patch
and it can be found in the queue-4.7 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let [off-list ref] know about it.
From d6e0d306449bcb5fa3c80e7a3edf11d45abf9ae9 Mon Sep 17 00:00:00 2001
From: Tyler Hicks <redacted> Date: Thu, 2 Jun 2016 23:43:22 -0500 Subject: net: Use ns_capable_noaudit() when determining net sysctl permissions From: Tyler Hicks <redacted> commit d6e0d306449bcb5fa3c80e7a3edf11d45abf9ae9 upstream. The capability check should not be audited since it is only being used to determine the inode permissions. A failed check does not indicate a violation of security policy but, when an LSM is enabled, a denial audit message was being generated. The denial audit message caused confusion for some application authors because root-running Go applications always triggered the denial. To prevent this confusion, the capability check in net_ctl_permissions() is switched to the noaudit variant. BugLink: https://launchpad.net/bugs/1465724 Signed-off-by: Tyler Hicks <redacted> Acked-by: Serge E. Hallyn <redacted> Signed-off-by: James Morris <redacted> Signed-off-by: Sasha Levin <redacted> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- net/sysctl_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/net/sysctl_net.c
+++ b/net/sysctl_net.c@@ -46,7 +46,7 @@ static int net_ctl_permissions(struct ct kgid_t root_gid = make_kgid(net->user_ns, 0); /* Allow network administrator to have same access as root. */ - if (ns_capable(net->user_ns, CAP_NET_ADMIN) || + if (ns_capable_noaudit(net->user_ns, CAP_NET_ADMIN) || uid_eq(root_uid, current_euid())) { int mode = (table->mode >> 6) & 7; return (mode << 6) | (mode << 3) | mode;
Patches currently in stable-queue which might be from tyhicks@canonical.com are queue-4.7/net-use-ns_capable_noaudit-when-determining-net-sysctl-permissions.patch queue-4.7/kernel-add-noaudit-variant-of-ns_capable.patch