Patch "usb: f_fs: off by one bug in _ffs_func_bind()" has been added to the 4.4-stable tree
From: <gregkh@linuxfoundation.org>
Date: 2016-08-17 12:53:33
This is a note to let you know that I've just added the patch titled
usb: f_fs: off by one bug in _ffs_func_bind()
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
usb-f_fs-off-by-one-bug-in-_ffs_func_bind.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let [off-list ref] know about it.
From 0015f9156092d07b3ec06d37d014328419d5832e Mon Sep 17 00:00:00 2001
From: Dan Carpenter <redacted>
Date: Sat, 28 May 2016 07:48:10 +0300
Subject: usb: f_fs: off by one bug in _ffs_func_bind()
From: Dan Carpenter <redacted>
commit 0015f9156092d07b3ec06d37d014328419d5832e upstream.
This loop is supposed to set all the .num[] values to -1 but it's off by
one so it skips the first element and sets one element past the end of
the array.
I've cleaned up the loop a little as well.
Fixes: ddf8abd25994 ('USB: f_fs: the FunctionFS driver')
Acked-by: Michal Nazarewicz <redacted>
Signed-off-by: Dan Carpenter <redacted>
Signed-off-by: Felipe Balbi <redacted>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/usb/gadget/function/f_fs.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
--- a/drivers/usb/gadget/function/f_fs.c
+++ b/drivers/usb/gadget/function/f_fs.c@@ -2740,6 +2740,7 @@ static int _ffs_func_bind(struct usb_con func->ffs->ss_descs_count; int fs_len, hs_len, ss_len, ret, i; + struct ffs_ep *eps_ptr; /* Make it a single chunk, less management later on */ vla_group(d);
@@ -2788,12 +2789,9 @@ static int _ffs_func_bind(struct usb_con ffs->raw_descs_length); memset(vla_ptr(vlabuf, d, inums), 0xff, d_inums__sz); - for (ret = ffs->eps_count; ret; --ret) { - struct ffs_ep *ptr; - - ptr = vla_ptr(vlabuf, d, eps); - ptr[ret].num = -1; - } + eps_ptr = vla_ptr(vlabuf, d, eps); + for (i = 0; i < ffs->eps_count; i++) + eps_ptr[i].num = -1; /* Save pointers * d_eps == vlabuf, func->eps used to kfree vlabuf later
Patches currently in stable-queue which might be from dan.carpenter@oracle.com are queue-4.4/usb-f_fs-off-by-one-bug-in-_ffs_func_bind.patch