--- v12
+++ v26
@@ -1,242 +1,300 @@
-The IMA interfaces ima_get_action() and ima_match_policy()
-call LSM functions that use lsmblobs. Change the IMA functions
-to pass the lsmblob to be compatible with the LSM functions.
+Change the security_cred_getsecid() interface to fill in a
+lsmblob instead of a u32 secid. The associated data elements
+in the audit sub-system are changed from a secid to a lsmblob
+to accommodate multiple possible LSM audit users.
Reviewed-by: Kees Cook <keescook@chromium.org>
Reviewed-by: John Johansen <john.johansen@canonical.com>
+Acked-by: Stephen Smalley <sds@tycho.nsa.gov>
+Acked-by: Paul Moore <paul@paul-moore.com>
Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
-cc: linux-integrity@vger.kernel.org
+Cc: linux-integrity@vger.kernel.org
+Cc: linux-audit@redhat.com
---
- security/integrity/ima/ima.h | 11 ++++-----
- security/integrity/ima/ima_api.c | 10 ++++-----
- security/integrity/ima/ima_appraise.c | 4 +---
- security/integrity/ima/ima_main.c | 32 +++++++++++----------------
- security/integrity/ima/ima_policy.c | 12 +++++-----
- 5 files changed, 31 insertions(+), 38 deletions(-)
+ include/linux/security.h | 2 +-
+ kernel/audit.c | 25 +++++++----------------
+ kernel/audit.h | 3 ++-
+ kernel/auditsc.c | 34 ++++++++++++-------------------
+ security/integrity/ima/ima_main.c | 8 ++++----
+ security/security.c | 12 ++++++++---
+ 6 files changed, 36 insertions(+), 48 deletions(-)
-diff --git a/security/integrity/ima/ima.h b/security/integrity/ima/ima.h
-index d95b0ece7434..96b6662ea39f 100644
---- a/security/integrity/ima/ima.h
-+++ b/security/integrity/ima/ima.h
-@@ -205,9 +205,9 @@ extern const char *const func_tokens[];
- struct modsig;
-
- /* LIM API function definitions */
--int ima_get_action(struct inode *inode, const struct cred *cred, u32 secid,
-- int mask, enum ima_hooks func, int *pcr,
-- struct ima_template_desc **template_desc);
-+int ima_get_action(struct inode *inode, const struct cred *cred,
-+ struct lsmblob *blob, int mask, enum ima_hooks func,
-+ int *pcr, struct ima_template_desc **template_desc);
- int ima_must_measure(struct inode *inode, int mask, enum ima_hooks func);
- int ima_collect_measurement(struct integrity_iint_cache *iint,
- struct file *file, void *buf, loff_t size,
-@@ -232,8 +232,9 @@ void ima_free_template_entry(struct ima_template_entry *entry);
- const char *ima_d_path(const struct path *path, char **pathbuf, char *filename);
-
- /* IMA policy related functions */
--int ima_match_policy(struct inode *inode, const struct cred *cred, u32 secid,
-- enum ima_hooks func, int mask, int flags, int *pcr,
-+int ima_match_policy(struct inode *inode, const struct cred *cred,
-+ struct lsmblob *blob, enum ima_hooks func, int mask,
-+ int flags, int *pcr,
- struct ima_template_desc **template_desc);
- void ima_init_policy(void);
- void ima_update_policy(void);
-diff --git a/security/integrity/ima/ima_api.c b/security/integrity/ima/ima_api.c
-index 610759fe63b8..1ab769fa7df6 100644
---- a/security/integrity/ima/ima_api.c
-+++ b/security/integrity/ima/ima_api.c
-@@ -163,7 +163,7 @@ void ima_add_violation(struct file *file, const unsigned char *filename,
- * ima_get_action - appraise & measure decision based on policy.
- * @inode: pointer to inode to measure
- * @cred: pointer to credentials structure to validate
-- * @secid: secid of the task being validated
-+ * @blob: LSM data of the task being validated
- * @mask: contains the permission mask (MAY_READ, MAY_WRITE, MAY_EXEC,
- * MAY_APPEND)
- * @func: caller identifier
-@@ -181,15 +181,15 @@ void ima_add_violation(struct file *file, const unsigned char *filename,
- * Returns IMA_MEASURE, IMA_APPRAISE mask.
- *
- */
--int ima_get_action(struct inode *inode, const struct cred *cred, u32 secid,
-- int mask, enum ima_hooks func, int *pcr,
-- struct ima_template_desc **template_desc)
-+int ima_get_action(struct inode *inode, const struct cred *cred,
-+ struct lsmblob *blob, int mask, enum ima_hooks func,
-+ int *pcr, struct ima_template_desc **template_desc)
- {
- int flags = IMA_MEASURE | IMA_AUDIT | IMA_APPRAISE | IMA_HASH;
-
- flags &= ima_policy_flag;
-
-- return ima_match_policy(inode, cred, secid, func, mask, flags, pcr,
-+ return ima_match_policy(inode, cred, blob, func, mask, flags, pcr,
- template_desc);
- }
-
-diff --git a/security/integrity/ima/ima_appraise.c b/security/integrity/ima/ima_appraise.c
-index 69e549164949..01c755a242ac 100644
---- a/security/integrity/ima/ima_appraise.c
-+++ b/security/integrity/ima/ima_appraise.c
-@@ -48,15 +48,13 @@ bool is_ima_appraise_enabled(void)
- */
- int ima_must_appraise(struct inode *inode, int mask, enum ima_hooks func)
- {
+diff --git a/include/linux/security.h b/include/linux/security.h
+index 64f898e5e854..c1c31eb23859 100644
+--- a/include/linux/security.h
++++ b/include/linux/security.h
+@@ -481,7 +481,7 @@ int security_cred_alloc_blank(struct cred *cred, gfp_t gfp);
+ void security_cred_free(struct cred *cred);
+ int security_prepare_creds(struct cred *new, const struct cred *old, gfp_t gfp);
+ void security_transfer_creds(struct cred *new, const struct cred *old);
+-void security_cred_getsecid(const struct cred *c, u32 *secid);
++void security_cred_getsecid(const struct cred *c, struct lsmblob *blob);
+ int security_kernel_act_as(struct cred *new, struct lsmblob *blob);
+ int security_kernel_create_files_as(struct cred *new, struct inode *inode);
+ int security_kernel_module_request(char *kmod_name);
+diff --git a/kernel/audit.c b/kernel/audit.c
+index d92c7b894183..8ec64e6e8bc0 100644
+--- a/kernel/audit.c
++++ b/kernel/audit.c
+@@ -125,7 +125,7 @@ static u32 audit_backlog_wait_time = AUDIT_BACKLOG_WAIT_TIME;
+ /* The identity of the user shutting down the audit system. */
+ static kuid_t audit_sig_uid = INVALID_UID;
+ static pid_t audit_sig_pid = -1;
+-static u32 audit_sig_sid;
++struct lsmblob audit_sig_lsm;
+
+ /* Records can be lost in several ways:
+ 0) [suppressed in audit_alloc]
+@@ -1441,29 +1441,21 @@ static int audit_receive_msg(struct sk_buff *skb, struct nlmsghdr *nlh)
+ }
+ case AUDIT_SIGNAL_INFO:
+ len = 0;
+- if (audit_sig_sid) {
+- struct lsmblob blob;
+-
+- /*
+- * lsmblob_init sets all values in the lsmblob
+- * to audit_sig_sid. This is temporary until
+- * audit_sig_sid is converted to a lsmblob, which
+- * happens later in this patch set.
+- */
+- lsmblob_init(&blob, audit_sig_sid);
+- err = security_secid_to_secctx(&blob, &ctx, &len);
++ if (lsmblob_is_set(&audit_sig_lsm)) {
++ err = security_secid_to_secctx(&audit_sig_lsm, &ctx,
++ &len);
+ if (err)
+ return err;
+ }
+ sig_data = kmalloc(sizeof(*sig_data) + len, GFP_KERNEL);
+ if (!sig_data) {
+- if (audit_sig_sid)
++ if (lsmblob_is_set(&audit_sig_lsm))
+ security_release_secctx(ctx, len);
+ return -ENOMEM;
+ }
+ sig_data->uid = from_kuid(&init_user_ns, audit_sig_uid);
+ sig_data->pid = audit_sig_pid;
+- if (audit_sig_sid) {
++ if (lsmblob_is_set(&audit_sig_lsm)) {
+ memcpy(sig_data->ctx, ctx, len);
+ security_release_secctx(ctx, len);
+ }
+@@ -2352,7 +2344,6 @@ int audit_set_loginuid(kuid_t loginuid)
+ int audit_signal_info(int sig, struct task_struct *t)
+ {
+ kuid_t uid = current_uid(), auid;
+- struct lsmblob blob;
+
+ if (auditd_test_task(t) &&
+ (sig == SIGTERM || sig == SIGHUP ||
+@@ -2363,9 +2354,7 @@ int audit_signal_info(int sig, struct task_struct *t)
+ audit_sig_uid = auid;
+ else
+ audit_sig_uid = uid;
+- security_task_getsecid_subj(current, &blob);
+- /* scaffolding until audit_sig_sid is converted */
+- audit_sig_sid = blob.secid[0];
++ security_task_getsecid_subj(current, &audit_sig_lsm);
+ }
+
+ return audit_signal_info_syscall(t);
+diff --git a/kernel/audit.h b/kernel/audit.h
+index 1522e100fd17..23a85a470121 100644
+--- a/kernel/audit.h
++++ b/kernel/audit.h
+@@ -9,6 +9,7 @@
+ #include <linux/fs.h>
+ #include <linux/audit.h>
+ #include <linux/skbuff.h>
++#include <linux/security.h>
+ #include <uapi/linux/mqueue.h>
+ #include <linux/tty.h>
+
+@@ -134,7 +135,7 @@ struct audit_context {
+ kuid_t target_auid;
+ kuid_t target_uid;
+ unsigned int target_sessionid;
+- u32 target_sid;
++ struct lsmblob target_lsm;
+ char target_comm[TASK_COMM_LEN];
+
+ struct audit_tree_refs *trees, *first_trees;
+diff --git a/kernel/auditsc.c b/kernel/auditsc.c
+index 6684927f12fc..573c6a8e505f 100644
+--- a/kernel/auditsc.c
++++ b/kernel/auditsc.c
+@@ -111,7 +111,7 @@ struct audit_aux_data_pids {
+ kuid_t target_auid[AUDIT_AUX_PIDS];
+ kuid_t target_uid[AUDIT_AUX_PIDS];
+ unsigned int target_sessionid[AUDIT_AUX_PIDS];
+- u32 target_sid[AUDIT_AUX_PIDS];
++ struct lsmblob target_lsm[AUDIT_AUX_PIDS];
+ char target_comm[AUDIT_AUX_PIDS][TASK_COMM_LEN];
+ int pid_count;
+ };
+@@ -991,14 +991,14 @@ static inline void audit_free_context(struct audit_context *context)
+ }
+
+ static int audit_log_pid_context(struct audit_context *context, pid_t pid,
+- kuid_t auid, kuid_t uid, unsigned int sessionid,
+- u32 sid, char *comm)
++ kuid_t auid, kuid_t uid,
++ unsigned int sessionid,
++ struct lsmblob *blob, char *comm)
+ {
+ struct audit_buffer *ab;
+ char *ctx = NULL;
+ u32 len;
+ int rc = 0;
+- struct lsmblob blob;
+
+ ab = audit_log_start(context, GFP_KERNEL, AUDIT_OBJ_PID);
+ if (!ab)
+@@ -1007,9 +1007,8 @@ static int audit_log_pid_context(struct audit_context *context, pid_t pid,
+ audit_log_format(ab, "opid=%d oauid=%d ouid=%d oses=%d", pid,
+ from_kuid(&init_user_ns, auid),
+ from_kuid(&init_user_ns, uid), sessionid);
+- if (sid) {
+- lsmblob_init(&blob, sid);
+- if (security_secid_to_secctx(&blob, &ctx, &len)) {
++ if (lsmblob_is_set(blob)) {
++ if (security_secid_to_secctx(blob, &ctx, &len)) {
+ audit_log_format(ab, " obj=(none)");
+ rc = 1;
+ } else {
+@@ -1580,7 +1579,7 @@ static void audit_log_exit(void)
+ axs->target_auid[i],
+ axs->target_uid[i],
+ axs->target_sessionid[i],
+- axs->target_sid[i],
++ &axs->target_lsm[i],
+ axs->target_comm[i]))
+ call_panic = 1;
+ }
+@@ -1589,7 +1588,7 @@ static void audit_log_exit(void)
+ audit_log_pid_context(context, context->target_pid,
+ context->target_auid, context->target_uid,
+ context->target_sessionid,
+- context->target_sid, context->target_comm))
++ &context->target_lsm, context->target_comm))
+ call_panic = 1;
+
+ if (context->pwd.dentry && context->pwd.mnt) {
+@@ -1765,7 +1764,7 @@ void __audit_syscall_exit(int success, long return_code)
+ context->aux = NULL;
+ context->aux_pids = NULL;
+ context->target_pid = 0;
+- context->target_sid = 0;
++ lsmblob_init(&context->target_lsm, 0);
+ context->sockaddr_len = 0;
+ context->type = 0;
+ context->fds[0] = -1;
+@@ -2319,6 +2318,7 @@ void __audit_ipc_obj(struct kern_ipc_perm *ipcp)
+ {
+ struct audit_context *context = audit_context();
+ struct lsmblob blob;
++
+ context->ipc.uid = ipcp->uid;
+ context->ipc.gid = ipcp->gid;
+ context->ipc.mode = ipcp->mode;
+@@ -2417,15 +2417,12 @@ int __audit_sockaddr(int len, void *a)
+ void __audit_ptrace(struct task_struct *t)
+ {
+ struct audit_context *context = audit_context();
+- struct lsmblob blob;
+
+ context->target_pid = task_tgid_nr(t);
+ context->target_auid = audit_get_loginuid(t);
+ context->target_uid = task_uid(t);
+ context->target_sessionid = audit_get_sessionid(t);
+- security_task_getsecid_obj(t, &blob);
+- /* scaffolding - until target_sid is converted */
+- context->target_sid = blob.secid[0];
++ security_task_getsecid_obj(t, &context->target_lsm);
+ memcpy(context->target_comm, t->comm, TASK_COMM_LEN);
+ }
+
+@@ -2441,7 +2438,6 @@ int audit_signal_info_syscall(struct task_struct *t)
+ struct audit_aux_data_pids *axp;
+ struct audit_context *ctx = audit_context();
+ kuid_t t_uid = task_uid(t);
+- struct lsmblob blob;
+
+ if (!audit_signals || audit_dummy_context())
+ return 0;
+@@ -2453,9 +2449,7 @@ int audit_signal_info_syscall(struct task_struct *t)
+ ctx->target_auid = audit_get_loginuid(t);
+ ctx->target_uid = t_uid;
+ ctx->target_sessionid = audit_get_sessionid(t);
+- security_task_getsecid_obj(t, &blob);
+- /* scaffolding until target_sid is converted */
+- ctx->target_sid = blob.secid[0];
++ security_task_getsecid_obj(t, &ctx->target_lsm);
+ memcpy(ctx->target_comm, t->comm, TASK_COMM_LEN);
+ return 0;
+ }
+@@ -2476,9 +2470,7 @@ int audit_signal_info_syscall(struct task_struct *t)
+ axp->target_auid[axp->pid_count] = audit_get_loginuid(t);
+ axp->target_uid[axp->pid_count] = t_uid;
+ axp->target_sessionid[axp->pid_count] = audit_get_sessionid(t);
+- security_task_getsecid_obj(t, &blob);
+- /* scaffolding until target_sid is converted */
+- axp->target_sid[axp->pid_count] = blob.secid[0];
++ security_task_getsecid_obj(t, &axp->target_lsm[axp->pid_count]);
+ memcpy(axp->target_comm[axp->pid_count], t->comm, TASK_COMM_LEN);
+ axp->pid_count++;
+
+diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c
+index 9d1ed00eb349..b3e00340a97c 100644
+--- a/security/integrity/ima/ima_main.c
++++ b/security/integrity/ima/ima_main.c
+@@ -470,7 +470,6 @@ int ima_file_mprotect(struct vm_area_struct *vma, unsigned long prot)
+ int ima_bprm_check(struct linux_binprm *bprm)
+ {
+ int ret;
- u32 secid;
struct lsmblob blob;
- if (!ima_appraise)
- return 0;
-
- security_task_getsecid(current, &blob);
-- lsmblob_secid(&blob, &secid);
-- return ima_match_policy(inode, current_cred(), secid, func, mask,
-+ return ima_match_policy(inode, current_cred(), &blob, func, mask,
- IMA_APPRAISE | IMA_HASH, NULL, NULL);
- }
-
-diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c
-index c8e3e234d446..86cc1419587e 100644
---- a/security/integrity/ima/ima_main.c
-+++ b/security/integrity/ima/ima_main.c
-@@ -190,8 +190,8 @@ void ima_file_free(struct file *file)
- }
-
- static int process_measurement(struct file *file, const struct cred *cred,
-- u32 secid, char *buf, loff_t size, int mask,
-- enum ima_hooks func)
-+ struct lsmblob *blob, char *buf, loff_t size,
-+ int mask, enum ima_hooks func)
- {
- struct inode *inode = file_inode(file);
- struct integrity_iint_cache *iint = NULL;
-@@ -214,7 +214,7 @@ static int process_measurement(struct file *file, const struct cred *cred,
- * bitmask based on the appraise/audit/measurement policy.
- * Included is the appraise submask.
- */
-- action = ima_get_action(inode, cred, secid, mask, func, &pcr,
-+ action = ima_get_action(inode, cred, blob, mask, func, &pcr,
- &template_desc);
- violation_check = ((func == FILE_CHECK || func == MMAP_CHECK) &&
- (ima_policy_flag & IMA_MEASURE));
-@@ -388,8 +388,7 @@ int ima_file_mmap(struct file *file, unsigned long prot)
-
- if (file && (prot & PROT_EXEC)) {
- security_task_getsecid(current, &blob);
-- /* scaffolding - until process_measurement changes */
-- return process_measurement(file, current_cred(), blob.secid[0],
-+ return process_measurement(file, current_cred(), &blob,
- NULL, 0, MAY_EXEC, MMAP_CHECK);
- }
-
-@@ -415,16 +414,14 @@ int ima_bprm_check(struct linux_binprm *bprm)
- struct lsmblob blob;
-
- security_task_getsecid(current, &blob);
-- /* scaffolding until process_measurement changes */
-- ret = process_measurement(bprm->file, current_cred(), blob.secid[0],
-- NULL, 0, MAY_EXEC, BPRM_CHECK);
-+ ret = process_measurement(bprm->file, current_cred(), &blob, NULL, 0,
-+ MAY_EXEC, BPRM_CHECK);
+ security_task_getsecid_subj(current, &blob);
+@@ -480,9 +479,10 @@ int ima_bprm_check(struct linux_binprm *bprm)
if (ret)
return ret;
- security_cred_getsecid(bprm->cred, &blob);
-- /* scaffolding until process_measurement changes */
-- return process_measurement(bprm->file, bprm->cred, blob.secid[0],
-- NULL, 0, MAY_EXEC, CREDS_CHECK);
-+ return process_measurement(bprm->file, bprm->cred, &blob, NULL, 0,
-+ MAY_EXEC, CREDS_CHECK);
+- security_cred_getsecid(bprm->cred, &secid);
+- return process_measurement(bprm->file, bprm->cred, secid, NULL, 0,
+- MAY_EXEC, CREDS_CHECK);
++ security_cred_getsecid(bprm->cred, &blob);
++ /* scaffolding until process_measurement changes */
++ return process_measurement(bprm->file, bprm->cred, blob.secid[0],
++ NULL, 0, MAY_EXEC, CREDS_CHECK);
}
/**
-@@ -442,8 +439,7 @@ int ima_file_check(struct file *file, int mask)
- struct lsmblob blob;
-
- security_task_getsecid(current, &blob);
-- /* scaffolding until process_measurement changes */
-- return process_measurement(file, current_cred(), blob.secid[0], NULL, 0,
-+ return process_measurement(file, current_cred(), &blob, NULL, 0,
- mask & (MAY_READ | MAY_WRITE | MAY_EXEC |
- MAY_APPEND), FILE_CHECK);
- }
-@@ -575,9 +571,8 @@ int ima_post_read_file(struct file *file, void *buf, loff_t size,
-
- func = read_idmap[read_id] ?: FILE_CHECK;
- security_task_getsecid(current, &blob);
-- /* scaffolding until process_measurement changes */
-- return process_measurement(file, current_cred(), blob.secid[0], buf,
-- size, MAY_READ, func);
-+ return process_measurement(file, current_cred(), &blob, buf, size,
-+ MAY_READ, func);
- }
-
- /**
-@@ -669,9 +664,8 @@ void process_buffer_measurement(const void *buf, int size,
- */
- if (func) {
- security_task_getsecid(current, &blob);
-- /* scaffolding */
-- action = ima_get_action(NULL, current_cred(), blob.secid[0],
-- 0, func, &pcr, &template);
-+ action = ima_get_action(NULL, current_cred(), &blob, 0, func,
-+ &pcr, &template);
- if (!(action & IMA_MEASURE))
- return;
- }
-diff --git a/security/integrity/ima/ima_policy.c b/security/integrity/ima/ima_policy.c
-index c7d2ea47a326..b089d4a8b27b 100644
---- a/security/integrity/ima/ima_policy.c
-+++ b/security/integrity/ima/ima_policy.c
-@@ -368,7 +368,7 @@ int ima_lsm_policy_change(struct notifier_block *nb, unsigned long event,
- * Returns true on rule match, false on failure.
- */
- static bool ima_match_rules(struct ima_rule_entry *rule, struct inode *inode,
-- const struct cred *cred, u32 secid,
-+ const struct cred *cred, struct lsmblob *blob,
- enum ima_hooks func, int mask)
- {
- int i;
-@@ -431,7 +431,6 @@ static bool ima_match_rules(struct ima_rule_entry *rule, struct inode *inode,
- case LSM_SUBJ_USER:
- case LSM_SUBJ_ROLE:
- case LSM_SUBJ_TYPE:
-- lsmblob_init(&blob, secid);
- rc = security_filter_rule_match(&blob,
- rule->lsm[i].type,
- Audit_equal,
-@@ -475,7 +474,7 @@ static int get_subaction(struct ima_rule_entry *rule, enum ima_hooks func)
- * @inode: pointer to an inode for which the policy decision is being made
- * @cred: pointer to a credentials structure for which the policy decision is
- * being made
-- * @secid: LSM secid of the task to be validated
-+ * @blob: LSM data of the task to be validated
- * @func: IMA hook identifier
- * @mask: requested action (MAY_READ | MAY_WRITE | MAY_APPEND | MAY_EXEC)
- * @pcr: set the pcr to extend
-@@ -488,8 +487,9 @@ static int get_subaction(struct ima_rule_entry *rule, enum ima_hooks func)
- * list when walking it. Reads are many orders of magnitude more numerous
- * than writes so ima_match_policy() is classical RCU candidate.
- */
--int ima_match_policy(struct inode *inode, const struct cred *cred, u32 secid,
-- enum ima_hooks func, int mask, int flags, int *pcr,
-+int ima_match_policy(struct inode *inode, const struct cred *cred,
-+ struct lsmblob *blob, enum ima_hooks func, int mask,
-+ int flags, int *pcr,
- struct ima_template_desc **template_desc)
- {
- struct ima_rule_entry *entry;
-@@ -504,7 +504,7 @@ int ima_match_policy(struct inode *inode, const struct cred *cred, u32 secid,
- if (!(entry->action & actmask))
- continue;
-
-- if (!ima_match_rules(entry, inode, cred, secid, func, mask))
-+ if (!ima_match_rules(entry, inode, cred, blob, func, mask))
- continue;
-
- action |= entry->flags & IMA_ACTION_FLAGS;
+diff --git a/security/security.c b/security/security.c
+index 54f4a4ead69f..f5407a85641e 100644
+--- a/security/security.c
++++ b/security/security.c
+@@ -1796,10 +1796,16 @@ void security_transfer_creds(struct cred *new, const struct cred *old)
+ call_void_hook(cred_transfer, new, old);
+ }
+
+-void security_cred_getsecid(const struct cred *c, u32 *secid)
++void security_cred_getsecid(const struct cred *c, struct lsmblob *blob)
+ {
+- *secid = 0;
+- call_void_hook(cred_getsecid, c, secid);
++ struct security_hook_list *hp;
++
++ lsmblob_init(blob, 0);
++ hlist_for_each_entry(hp, &security_hook_heads.cred_getsecid, list) {
++ if (WARN_ON(hp->lsmid->slot < 0 || hp->lsmid->slot >= lsm_slot))
++ continue;
++ hp->hook.cred_getsecid(c, &blob->secid[hp->lsmid->slot]);
++ }
+ }
+ EXPORT_SYMBOL(security_cred_getsecid);
+
--
-2.20.1
+2.29.2