Reviews by gary@garyguo.net · nova-gpu

All review-attestation trailers (Reviewed-by / Acked-by / Tested-by / Reported-by / Suggested-by / Co-developed-by / Reported-and-tested-by) by this address on the nova-gpu archive.

100 attestations · capped at 100 most-recent. (4 Co-developed-by, 1 Reported-by, 83 Reviewed-by, 12 Suggested-by)

• WARM2d REVIEWED: 4 (4M) Re: [PATCH v8 07/10] rust: configfs: use `LocalModule` for `THIS_MODULE`
  2026-07-13 · Reviewed-by
• WARM2d REVIEWED: 19 (19M) [PATCH v8 01/10] rust: module: move module types into `module.rs`
  2026-07-13 · Reviewed-by
• WARM2d REVIEWED: 25 (25M) [PATCH v8 02/10] rust: module: add `THIS_MODULE` const to `ModuleMetadata` trait
  2026-07-13 · Reviewed-by
• WARM2d REVIEWED: 25 (25M) [PATCH v8 03/10] rust: doctest: add LocalModule fallback for #[vtable] ThisModule
  2026-07-13 · Reviewed-by
• WARM2d REVIEWED: 25 (25M) [PATCH v8 04/10] rust: macros: auto-insert OwnerModule in #[vtable]
  2026-07-13 · Reviewed-by
• WARM2d REVIEWED: 25 (25M) [PATCH v8 05/10] rust: drm: set fops.owner from driver module pointer
  2026-07-13 · Reviewed-by
• WARM2d REVIEWED: 25 (25M) [PATCH v8 06/10] rust: miscdevice: set fops.owner from driver module pointer
  2026-07-13 · Reviewed-by
• WARM2d REVIEWED: 19 (19M) [PATCH v8 08/10] rust: binder: use `LocalModule` for `THIS_MODULE`
  2026-07-13 · Reviewed-by
• WARM2d REVIEWED: 25 (25M) [PATCH v8 09/10] rust: macros: remove `THIS_MODULE` static from `module!`
  2026-07-13 · Reviewed-by
• WARM2d REVIEWED: 19 (19M) [PATCH v8 01/10] rust: module: move module types into `module.rs`
  2026-07-13 · Suggested-by
• WARM2d REVIEWED: 25 (25M) [PATCH v8 04/10] rust: macros: auto-insert OwnerModule in #[vtable]
  2026-07-13 · Suggested-by
• WARM3d REVIEWED: 5 (5M) [PATCH v6 14/20] rust: io: add I/O backend for system memory with volatile access
  2026-07-06 · Co-developed-by
• COOLING5d REVIEWED: 4 (4M) Re: [PATCH v4 2/7] rust: types: introduce ForLt base trait for CovariantForLt
  2026-06-30 · Reviewed-by
• COOLING4d [PATCH v5 01/19] rust: drm: ioctl: fix unbounded lifetimes in ioctl handler arguments
  2026-06-28 · Suggested-by
• DORMANTno replies REVIEWED: 25 (25M) [PATCH v7 06/10] rust: miscdevice: set fops.owner from driver module pointer
  2026-06-27 · Reviewed-by
• DORMANTno replies REVIEWED: 19 (19M) [PATCH v7 08/10] rust: binder: use `LocalModule` for `THIS_MODULE`
  2026-06-27 · Reviewed-by
• DORMANTno replies REVIEWED: 25 (25M) [PATCH v7 09/10] rust: macros: remove `THIS_MODULE` static from `module!`
  2026-06-27 · Reviewed-by
• COLD20d REVIEWED: 25 (25M) [PATCH v7 02/10] rust: module: add `THIS_MODULE` const to `ModuleMetadata` trait
  2026-06-27 · Reviewed-by
• COLD20d REVIEWED: 25 (25M) [PATCH v7 03/10] rust: doctest: add LocalModule fallback for #[vtable] ThisModule
  2026-06-27 · Reviewed-by
• COLD20d REVIEWED: 25 (25M) [PATCH v7 04/10] rust: macros: auto-insert OwnerModule in #[vtable]
  2026-06-27 · Reviewed-by
• COLD20d REVIEWED: 25 (25M) [PATCH v7 05/10] rust: drm: set fops.owner from driver module pointer
  2026-06-27 · Reviewed-by
• COLD20d REVIEWED: 25 (25M) [PATCH v7 04/10] rust: macros: auto-insert OwnerModule in #[vtable]
  2026-06-27 · Suggested-by
• COOLING5d REVIEWED: 9 (9M) [PATCH v4 4/7] rust: auxiliary: sample: demonstrate ForLt with invariant Mutex type
  2026-06-26 · Reviewed-by
• COOLING5d REVIEWED: 9 (9M) [PATCH v4 3/7] rust: auxiliary: add registration_data_with() for ForLt types
  2026-06-26 · Reviewed-by
• COOLING5d REVIEWED: 9 (9M) [PATCH v4 1/7] rust: types: rename ForLt to CovariantForLt
  2026-06-26 · Reviewed-by
• COOLING11d [PATCH v5 14/20] rust: io: add I/O backend for system memory with volatile access
  2026-06-26 · Co-developed-by
• COLD19d REVIEWED: 4 (4M) Re: [PATCH v6 01/10] rust: module: move module types into `module.rs`
  2026-06-25 · Reviewed-by
• COLD19d REVIEWED: 4 (4M) Re: [PATCH v6 01/10] rust: module: move module types into `module.rs`
  2026-06-25 · Suggested-by
• COLD21d REVIEWED: 4 (4M) Re: [PATCH v3 4/7] rust: auxiliary: sample: demonstrate ForLt with invariant Mutex type
  2026-06-25 · Reviewed-by
• COLD21d REVIEWED: 4 (4M) Re: [PATCH v3 3/7] rust: auxiliary: add registration_data_with() for ForLt types
  2026-06-25 · Reviewed-by
• COLD21d REVIEWED: 4 (4M) Re: [PATCH v3 1/7] rust: types: rename ForLt to CovariantForLt
  2026-06-24 · Reviewed-by
• COLD19d REVIEWED: 19 (19M) [PATCH v6 08/10] rust: binder: use `LocalModule` for `THIS_MODULE`
  2026-06-24 · Reviewed-by
• COLD19d REVIEWED: 25 (25M) [PATCH v6 09/10] rust: macros: remove `THIS_MODULE` static from `module!`
  2026-06-24 · Reviewed-by
• COLD19d REVIEWED: 25 (25M) [PATCH v6 02/10] rust: module: add `THIS_MODULE` const to `ModuleMetadata` trait
  2026-06-24 · Reviewed-by
• COLD19d REVIEWED: 25 (25M) [PATCH v6 03/10] rust: doctest: add LocalModule fallback for #[vtable] ThisModule
  2026-06-24 · Reviewed-by
• COLD19d REVIEWED: 25 (25M) [PATCH v6 04/10] rust: macros: auto-insert OwnerModule in #[vtable]
  2026-06-24 · Reviewed-by
• COLD19d REVIEWED: 25 (25M) [PATCH v6 05/10] rust: drm: set fops.owner from driver module pointer
  2026-06-24 · Reviewed-by
• COLD19d REVIEWED: 25 (25M) [PATCH v6 06/10] rust: miscdevice: set fops.owner from driver module pointer
  2026-06-24 · Reviewed-by
• COLD19d REVIEWED: 25 (25M) [PATCH v6 04/10] rust: macros: auto-insert OwnerModule in #[vtable]
  2026-06-24 · Suggested-by
• COLD22d REVIEWED: 4 (4M) [PATCH v5 8/9] rust: binder: use `LocalModule` for `THIS_MODULE`
  2026-06-24 · Reviewed-by
• COLD22d REVIEWED: 10 (10M) [PATCH v5 9/9] rust: macros: remove `THIS_MODULE` static from `module!`
  2026-06-24 · Reviewed-by
• COLD22d REVIEWED: 10 (10M) [PATCH v5 2/9] rust: module: add `THIS_MODULE` const to `ModuleMetadata` trait
  2026-06-24 · Reviewed-by
• COLD22d REVIEWED: 10 (10M) [PATCH v5 3/9] rust: doctest: add LocalModule fallback for #[vtable] ThisModule
  2026-06-24 · Reviewed-by
• COLD22d REVIEWED: 10 (10M) [PATCH v5 4/9] rust: macros: auto-insert OwnerModule in #[vtable]
  2026-06-24 · Reviewed-by
• COLD22d REVIEWED: 10 (10M) [PATCH v5 5/9] rust: drm: set fops.owner from driver module pointer
  2026-06-24 · Reviewed-by
• COLD22d REVIEWED: 10 (10M) [PATCH v5 6/9] rust: miscdevice: set fops.owner from driver module pointer
  2026-06-24 · Reviewed-by
• COLD22d REVIEWED: 10 (10M) [PATCH v5 4/9] rust: macros: auto-insert OwnerModule in #[vtable]
  2026-06-24 · Suggested-by
• DORMANTno replies REVIEWED: 4 (4M) Re: [PATCH v4 9/9] rust: macros: remove `THIS_MODULE` static from `module!`
  2026-06-23 · Reviewed-by
• COLD23d REVIEWED: 4 (4M) Re: [PATCH v4 8/9] rust: binder: use `LocalModule` for `THIS_MODULE`
  2026-06-23 · Reviewed-by
• COLD23d REVIEWED: 4 (4M) Re: [PATCH v4 6/9] rust: miscdevice: set fops.owner from driver module pointer
  2026-06-23 · Reviewed-by
• COLD23d REVIEWED: 4 (4M) Re: [PATCH v4 4/9] rust: macros: auto-insert OwnerModule in #[vtable]
  2026-06-23 · Reviewed-by
• COLD23d REVIEWED: 4 (4M) Re: [PATCH v4 3/9] rust: doctest: add LocalModule fallback for #[vtable] ThisModule
  2026-06-23 · Reviewed-by
• COLD23d REVIEWED: 4 (4M) Re: [PATCH v4 2/9] rust: module: add `THIS_MODULE` const to `ModuleMetadata` trait
  2026-06-23 · Reviewed-by
• COLD23d REVIEWED: 10 (10M) [PATCH v4 5/9] rust: drm: set fops.owner from driver module pointer
  2026-06-23 · Reviewed-by
• COLD23d REVIEWED: 6 (6M) [PATCH v4 4/9] rust: macros: auto-insert OwnerModule in #[vtable]
  2026-06-23 · Suggested-by
• COLD24d REVIEWED: 4 (4M) Re: [PATCH v3 4/6] rust: drm: set fops.owner from driver module pointer
  2026-06-22 · Reviewed-by
• COLD24d REVIEWED: 4 (4M) Re: [PATCH v3 3/6] rust: macros: auto-insert OwnerModule in #[vtable]
  2026-06-22 · Reviewed-by
• COLD24d REVIEWED: 6 (6M) [PATCH v3 3/6] rust: macros: auto-insert OwnerModule in #[vtable]
  2026-06-22 · Suggested-by
• COLD25d Re: [PATCH v2 2/7] rust: macros: auto-insert ThisModule in #[vtable]
  2026-06-18 · Suggested-by
• COLD23d REVIEWED: 4 (4M) Re: [PATCH 06/13] gpu: nova-core: fsp: move FMC firmware loading into wait_secure_boot
  2026-06-15 · Reviewed-by
• COLD23d REVIEWED: 4 (4M) Re: [PATCH 04/13] gpu: nova-core: falcon: gsp: move PRIV target mask constants
  2026-06-15 · Reviewed-by
• COLD23d REVIEWED: 4 (4M) Re: [PATCH 01/13] gpu: nova-core: fsp: limit FSP receive message allocation size
  2026-06-15 · Reviewed-by
• COLD25d [PATCH v4 14/20] rust: io: add I/O backend for system memory with volatile access
  2026-06-11 · Co-developed-by
• COLD36d [PATCH v3 13/19] rust: io: add I/O backend for system memory with volatile access
  2026-06-08 · Co-developed-by
• COLD39d REVIEWED: 4 (4M) [PATCH v4 1/6] rust: inline some init methods
  2026-06-05 · Reviewed-by
• COLD42d REVIEWED: 4 (4M) Re: [PATCH v3 1/5] rust: inline some init methods
  2026-06-03 · Reviewed-by
• COLD43d REVIEWED: 19 (19M) [PATCH v12 01/22] gpu: nova-core: set DMA mask width based on GPU architecture
  2026-06-02 · Reviewed-by
• COLD50d REVIEWED: 4 (4M) Re: [PATCH v5 20/24] samples: rust: rust_driver_pci: use HRT lifetime for Bar
  2026-05-27 · Reviewed-by
• COLD50d REVIEWED: 4 (4M) Re: [PATCH v5 21/24] gpu: nova-core: separate driver type from driver data
  2026-05-27 · Reviewed-by
• COLD50d REVIEWED: 4 (4M) Re: [PATCH v5 19/24] rust: io: make IoMem and ExclusiveIoMem lifetime-parameterized
  2026-05-27 · Reviewed-by
• COLD50d REVIEWED: 4 (4M) Re: [PATCH v5 18/24] rust: pci: make Bar lifetime-parameterized
  2026-05-27 · Reviewed-by
• COLD50d REVIEWED: 4 (4M) Re: [PATCH v5 17/24] rust: driver: update module documentation for GAT-based Data type
  2026-05-27 · Reviewed-by
• COLD50d REVIEWED: 4 (4M) Re: [PATCH v5 16/24] rust: i2c: make Driver trait lifetime-parameterized
  2026-05-27 · Reviewed-by
• COLD50d REVIEWED: 4 (4M) Re: [PATCH v5 15/24] rust: usb: make Driver trait lifetime-parameterized
  2026-05-27 · Reviewed-by
• COLD50d REVIEWED: 4 (4M) Re: [PATCH v5 14/24] rust: auxiliary: make Driver trait lifetime-parameterized
  2026-05-27 · Reviewed-by
• COLD50d REVIEWED: 4 (4M) Re: [PATCH v5 13/24] rust: platform: make Driver trait lifetime-parameterized
  2026-05-27 · Reviewed-by
• COLD50d REVIEWED: 4 (4M) Re: [PATCH v5 12/24] rust: pci: make Driver trait lifetime-parameterized
  2026-05-27 · Reviewed-by
• COLD50d REVIEWED: 4 (4M) Re: [PATCH v5 11/24] rust: device: make Core and CoreInternal lifetime-parameterized
  2026-05-27 · Reviewed-by
• COLD41d [PATCH v4 2/7] rust: bitfield: inline private accessors
  2026-05-27 · Reported-by
• COLD50d REVIEWED: 4 (4M) Re: [PATCH v5 01/24] rust: pci: use 'static lifetime for PCI BAR resource names
  2026-05-27 · Reviewed-by
• COLD50d REVIEWED: 28 (27M) [PATCH v5 24/24] samples: rust: rust_driver_auxiliary: showcase lifetime-bound registration data
  2026-05-25 · Reviewed-by
• COLD50d REVIEWED: 24 (23M) [PATCH v5 11/24] rust: device: make Core and CoreInternal lifetime-parameterized
  2026-05-25 · Suggested-by
• COLD50d REVIEWED: 27 (27M) [PATCH v5 10/24] rust: device: implement Sync for Device<Bound>
  2026-05-25 · Reviewed-by
• COLD50d REVIEWED: 27 (27M) [PATCH v5 09/24] rust: usb: implement Sync for Device<Bound>
  2026-05-25 · Reviewed-by
• COLD50d REVIEWED: 27 (27M) [PATCH v5 08/24] rust: auxiliary: implement Sync for Device<Bound>
  2026-05-25 · Reviewed-by
• COLD50d REVIEWED: 27 (27M) [PATCH v5 07/24] rust: platform: implement Sync for Device<Bound>
  2026-05-25 · Reviewed-by
• COLD50d REVIEWED: 27 (27M) [PATCH v5 06/24] rust: pci: implement Sync for Device<Bound>
  2026-05-25 · Reviewed-by
• COLD50d REVIEWED: 27 (27M) [PATCH v5 05/24] rust: driver core: drop drvdata before devres release
  2026-05-25 · Reviewed-by
• COLD50d REVIEWED: 27 (27M) [PATCH v5 04/24] rust: driver: decouple driver private data from driver type
  2026-05-25 · Reviewed-by
• COLD52d REVIEWED: 5 (4M) [PATCH v4 23/27] samples: rust: rust_driver_auxiliary: showcase lifetime-bound registration data
  2026-05-21 · Reviewed-by
• COLD52d [PATCH v4 10/27] rust: device: make Core and CoreInternal lifetime-parameterized
  2026-05-21 · Suggested-by
• COLD52d REVIEWED: 9 (9M) [PATCH v4 09/27] rust: device: implement Sync for Device<Bound>
  2026-05-21 · Reviewed-by
• COLD52d REVIEWED: 9 (9M) [PATCH v4 08/27] rust: usb: implement Sync for Device<Bound>
  2026-05-21 · Reviewed-by
• COLD52d REVIEWED: 9 (9M) [PATCH v4 07/27] rust: auxiliary: implement Sync for Device<Bound>
  2026-05-21 · Reviewed-by
• COLD52d REVIEWED: 9 (9M) [PATCH v4 06/27] rust: platform: implement Sync for Device<Bound>
  2026-05-21 · Reviewed-by
• COLD52d REVIEWED: 9 (9M) [PATCH v4 05/27] rust: pci: implement Sync for Device<Bound>
  2026-05-21 · Reviewed-by
• COLD52d REVIEWED: 9 (9M) [PATCH v4 04/27] rust: driver core: drop drvdata before devres release
  2026-05-21 · Reviewed-by
• COLD52d REVIEWED: 9 (9M) [PATCH v4 03/27] rust: driver: decouple driver private data from driver type
  2026-05-21 · Reviewed-by
• COLD49d REVIEWED: 5 (4M) [PATCH v6 1/7] gpu: nova-core: remove unneeded get_gsp_info proxy function
  2026-05-21 · Reviewed-by
• COLD58d REVIEWED: 4 (4M) Re: [PATCH v3 18/27] samples: rust: rust_driver_auxiliary: showcase lifetime-bound registration data
  2026-05-19 · Reviewed-by