Inter-revision diff: cover letter

Comparing v12 (message) to v8 (message)

--- v12
+++ v8
@@ -1,23 +1,17 @@
-Rework value and type of mdio read and write functions in mtk_eth_soc
-and generally clean up and unify both functions.
-Then add support to access Clause 45 phy registers, using newly
-introduced helper macros added by a patch Russell King has suggested
-in a reply to an earlier version of this series [1].
+As it turned out some clean-up would be needed, first address return
+value and type of mdio read and write functions in mtk_eth_soc and
+generally clean up and unify both functions.
+Also refactor IAC register definitions to use bitfield helper macros
+to get rid of constants previously used as mask or shift values.
+Then add support to access Clause 45 phy registers, using the newly
+introcuced helper macros suggested by Russell King to access the
+Clause 45 device and register address encoded in the 32-bit parameter.
 
-All three commits are tested on the Bananapi BPi-R64 board having
-MediaTek MT7531BE DSA gigE switch using clause 22 MDIO and
-Ubiquiti UniFi 6 LR access point having Aquantia AQR112C PHY using
-clause 45 MDIO.
+This series is tested on MediaTek MT7622AV based Bananapi BPi-R64 board
+having MediaTek MT7531BE DSA gigE switch using Clause 22 MDIO and
+MediaTek MT7622BV based Ubiquiti UniFi 6 LR access point having
+Aquantia AQR112C PHY using Clause 45 MDIO.
 
-[1]: https://lore.kernel.org/netdev/Ycr5Cna76eg2B0An@shell.armlinux.org.uk/
-
-v12: replace 'ret != 0' forgotten from an earlier iteration with
-     'ret < 0' checks of mtk_mdio_busy_wait return value (purely
-     cosmetical as anyway either 0 or -ETIMEDOUT is returned, sorry
-     for the noise)
-v11: also address return value of mtk_mdio_busy_wait
-v10: correct order of SoB lines in 2/3, change patch order in series
-v9: improved formatting and Cc missing maintainer
 v8: add patch from Russel King, switch to bitfield helper macros
 v7: remove unneeded variables and order OR-ed call parameters
 v6: further clean up functions and more cleanly separate patches
@@ -30,16 +24,16 @@
     anyway already replacing both function bodies.
 
 Daniel Golle (2):
-  net: ethernet: mtk_eth_soc: fix return values and refactor MDIO ops
+  net: ethernet: mtk_eth_soc: fix return value and refactor MDIO ops
   net: ethernet: mtk_eth_soc: implement Clause 45 MDIO access
 
 Russell King (Oracle) (1):
   net: mdio: add helpers to extract clause 45 regad and devad fields
 
- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 101 +++++++++++++++-----
- drivers/net/ethernet/mediatek/mtk_eth_soc.h |  19 +++-
- include/linux/mdio.h                        |  12 +++
- 3 files changed, 102 insertions(+), 30 deletions(-)
+ drivers/net/ethernet/mediatek/mtk_eth_soc.c | 73 ++++++++++++++-------
+ drivers/net/ethernet/mediatek/mtk_eth_soc.h | 19 ++++--
+ include/linux/mdio.h                        | 12 ++++
+ 3 files changed, 77 insertions(+), 27 deletions(-)
 
 -- 
 2.34.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help