According to the AQR113 PHY databook, after firmware reset, a 20ms
timer needs to be engaged to allow the supplies to settle prior to
allowing the PHY to boot. The working flow is:
-After the 20 ms timer has completed, hardware state machines
designed to guarantee PLL and band-gap stability engage.
-After the PLLs and band-gap are locked and functioning properly,
the processor and digital circuitry are released from reset.
-The PHY image is then loaded through MDIO boot-load and the
processor boots.
-After the processor boots, any provisioned register values are
set, and the PHY enters the provisioned operating state.
Starting subsequent firmware operations before the provision ID is
valid leads to steady link failures; this has been observed during
AQR113 PHY bring-up.
Also the provisioning ID is a component of the firmware fingerprint
used to identify the host interface mode for PHYs like AQR412C. When
such a PHY is provisioned with MUSX firmware, the fingerprint
determines whether the host interface should be reported as 10G-QXGMII
rather than USXGMII. Without a valid provisioning ID, the fingerprint
cannot be correctly built, making USXGMII and 10G-QXGMII
indistinguishable and potentially causing an interface mismatch.
Poll VEND1_GLOBAL_RSVD_STAT1 until the provision ID field is non-zero
before returning from aqr_wait_reset_complete(). A timeout indicates
a hardware-level provisioning failure that software cannot remediate;
the warning is logged to flag the hardware problem, but probe is not
failed since not all PHYs require a valid provision ID.
Co-developed-by: Sagar Cheluvegowda <redacted>
Signed-off-by: Sagar Cheluvegowda <redacted>
Signed-off-by: Hongmei Xu <redacted>
---
Changes in v3:
- Merge split string in phydev_warn() into a single line per kernel coding style
- Link to v2: https://patch.msgid.link/20261111-aquantia-poll-global-status-register-v2-1-b602fc7e80a9@oss.qualcomm.com (local)
Changes in v2:
- Change the log when provisioning ID poll times out to hint the
mode mismatch possibility
- Update commit message to describe the AQR113 databook boot sequence
and explain why polling PROV_ID is necessary
- Update commit message to explain that timeout prevents fingerprint
construction for PHYs like AQR412C with MUSX firmware which in a result cause mode mismatch
- Link to v1: https://patch.msgid.link/20261029-aquantia-poll-global-status-register-v1-1-808089824a3d@oss.qualcomm.com (local)
---
drivers/net/phy/aquantia/aquantia_main.c | 17 ++++++++++++++++-
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/drivers/net/phy/aquantia/aquantia_main.c b/drivers/net/phy/aquantia/aquantia_main.c
index e95d391a6dc2..b90221f1cf41 100644
--- a/drivers/net/phy/aquantia/aquantia_main.c
+++ b/drivers/net/phy/aquantia/aquantia_main.c
@@ -702,7 +702,22 @@ int aqr_wait_reset_complete(struct phy_device *phydev)
return val;
}
- return ret;
+ if (ret)
+ return ret;
+
+ ret = read_poll_timeout(phy_read_mmd, val,
+ val < 0 ||
+ FIELD_GET(VEND1_GLOBAL_RSVD_STAT1_PROV_ID, val),
+ AQR_FW_WAIT_SLEEP_US, AQR_FW_WAIT_TIMEOUT_US,
+ false, phydev, MDIO_MMD_VEND1,
+ VEND1_GLOBAL_RSVD_STAT1);
+ if (val < 0)
+ phydev_warn(phydev, "Failed to read VEND1_GLOBAL_RSVD_STAT1: %pe\n",
+ ERR_PTR(val));
+ else if (ret)
+ phydev_warn(phydev, "Firmware provisioning ID not ready; interface mode detection may be incorrect\n");
+
+ return 0;
}
static int aqr_build_fingerprint(struct phy_device *phydev)
---
base-commit: 944ae66642b726bd6b25ae71b1e9ff88a0e0bdb0
change-id: 20260923-aquantia-poll-global-status-register-d8966a46e56d
Best regards,
--
Hongmei Xu [off-list ref]