{1..16384} is bash-specific brace expansion and will not work with POSIX
shells like dash or busybox ash. This breaks the flowlabel test when
/bin/sh is not bash.
Use $(seq 1 16384) for portable iteration. Fix the same issue in
custom_multipath_hash.sh, gre_custom_multipath_hash.sh and
ip6gre_custom_multipath_hash.sh.
Fixes: 555e5531635a ("selftests: net/forwarding: spawn sh inside vrf to speed up ping loop")
Signed-off-by: Jin Li <redacted>
---
v2:
- Add Fixes tag
.../selftests/net/forwarding/custom_multipath_hash.sh | 8 ++++----
.../selftests/net/forwarding/gre_custom_multipath_hash.sh | 8 ++++----
.../net/forwarding/ip6gre_custom_multipath_hash.sh | 8 ++++----
3 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/tools/testing/selftests/net/forwarding/custom_multipath_hash.sh b/tools/testing/selftests/net/forwarding/custom_multipath_hash.sh
index 5dbfab0e2..92940370e 100755
--- a/tools/testing/selftests/net/forwarding/custom_multipath_hash.sh
+++ b/tools/testing/selftests/net/forwarding/custom_multipath_hash.sh
@@ -224,10 +224,10 @@ send_dst_ipv6()
send_flowlabel()
{
# Generate 16384 echo requests, each with a random flow label.
- ip vrf exec v$h1 sh -c \
- "for _ in {1..16384}; do \
- $PING6 -F 0 -c 1 -q 2001:db8:4::2 >/dev/null 2>&1; \
- done"
+ ip vrf exec v$h1 sh -c '
+ for _ in $(seq 1 16384); do
+ '"$PING6"' -F 0 -c 1 -q 2001:db8:4::2 >/dev/null 2>&1
+ done'
}
send_src_udp6()diff --git a/tools/testing/selftests/net/forwarding/gre_custom_multipath_hash.sh b/tools/testing/selftests/net/forwarding/gre_custom_multipath_hash.sh
index b4f17a5bb..19384be4b 100755
--- a/tools/testing/selftests/net/forwarding/gre_custom_multipath_hash.sh
+++ b/tools/testing/selftests/net/forwarding/gre_custom_multipath_hash.sh
@@ -319,10 +319,10 @@ send_dst_ipv6()
send_flowlabel()
{
# Generate 16384 echo requests, each with a random flow label.
- ip vrf exec v$h1 sh -c \
- "for _ in {1..16384}; do \
- $PING6 -F 0 -c 1 -q 2001:db8:2::2 >/dev/null 2>&1; \
- done"
+ ip vrf exec v$h1 sh -c '
+ for _ in $(seq 1 16384); do
+ '"$PING6"' -F 0 -c 1 -q 2001:db8:2::2 >/dev/null 2>&1
+ done'
}
send_src_udp6()diff --git a/tools/testing/selftests/net/forwarding/ip6gre_custom_multipath_hash.sh b/tools/testing/selftests/net/forwarding/ip6gre_custom_multipath_hash.sh
index b24acfa52..d848e82d4 100755
--- a/tools/testing/selftests/net/forwarding/ip6gre_custom_multipath_hash.sh
+++ b/tools/testing/selftests/net/forwarding/ip6gre_custom_multipath_hash.sh
@@ -321,10 +321,10 @@ send_dst_ipv6()
send_flowlabel()
{
# Generate 16384 echo requests, each with a random flow label.
- ip vrf exec v$h1 sh -c \
- "for _ in {1..16384}; do \
- $PING6 -F 0 -c 1 -q 2001:db8:2::2 >/dev/null 2>&1; \
- done"
+ ip vrf exec v$h1 sh -c '
+ for _ in $(seq 1 16384); do
+ '"$PING6"' -F 0 -c 1 -q 2001:db8:2::2 >/dev/null 2>&1
+ done'
}
send_src_udp6()--
2.53.0