# \[PATCH net 0/2\] net: macb: two fixes for macb\_tx\_error\_task() - From: Nicolai Buchwitz \ - Date: 2026-11-07 20:59:37 - List: netdev - Page: https://ratatoskr.run/netdev/2026/11/17890847 - Thread: https://ratatoskr.run/netdev/2026/11/17890847/t.md ```text Both pre-existing bugs were flagged during the clashiko review of my software FCS patch [1]. These are the promised follow-up patches. Patch 1 credits the frames dropped on a TX error to BQL. Patch 2 takes tx_ptr_lock in the task, as macb_start_xmit() moves the same pointers under it. Tested on a Raspberry Pi CM5 (RP1 GEM). The bugs are hard to reproduce and the error path never fired there, but they are worth fixing anyway. [1] https://lore.kernel.org/netdev/d1f02ab923c0464fa73cafa75a21943d@tipi-net.de/ Signed-off-by: Nicolai Buchwitz --- Nicolai Buchwitz (2): net: macb: credit unsent frames to BQL in macb_tx_error_task() net: macb: take tx_ptr_lock in macb_tx_error_task() drivers/net/ethernet/cadence/macb_main.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) --- base-commit: 30c71476d842b094651bd7712f6c8ee8716147d0 change-id: 20261107-nb-macb-tx-error-task-net-e8a553b4d138 Best regards, -- Nicolai Buchwitz [ref] ```