# \[PATCH net-next v01 1/4\] Fixes: Solve an LRO stall issue - From: Fan Gong \ - Date: 2026-11-06 06:14:45 - List: netdev - Page: https://ratatoskr.run/netdev/2026/11/17875984 - Thread: https://ratatoskr.run/netdev/2026/11/17875983/t.md ```text As noted in the subsequent review. This changes the return value when the loop exits on the LRO replenish threshold. It used to return nr_pkts and now returns budget. In hinic3_poll(): work_done = hinic3_rx_poll(irq_cfg->rxq, budget); busy |= work_done >= budget; if (busy) return budget; As a result, the threshold exit now skips napi_complete_done(), hinic3_net_dim() and the MSI-X re-enable. NAPI keeps polling instead of waiting for the next interrupt. This seems unrelated to statistics, and the commit message does not mention it. Was it intended? If it fixes an LRO stall, could it go in a separate patch with its own explanation and a Fixes: tag? Co-developed-by: Wu Di Signed-off-by: Wu Di Co-developed-by: Teng Peisen Signed-off-by: Teng Peisen Signed-off-by: Fan Gong --- drivers/net/ethernet/huawei/hinic3/hinic3_rx.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/huawei/hinic3/hinic3_rx.c b/drivers/net/ethernet/huawei/hinic3/hinic3_rx.c index 309ab5901379..9c4ab88998d4 100644 --- a/drivers/net/ethernet/huawei/hinic3/hinic3_rx.c +++ b/drivers/net/ethernet/huawei/hinic3/hinic3_rx.c @@ -555,6 +555,7 @@ int hinic3_rx_poll(struct hinic3_rxq *rxq, int budget) struct hinic3_nic_dev *nic_dev = netdev_priv(rxq->netdev); u32 sw_ci, status, pkt_len, vlan_len; struct hinic3_rq_cqe *rx_cqe; + bool poll_again = false; u32 num_wqe = 0; int nr_pkts = 0; u16 num_lro; @@ -581,12 +582,14 @@ int hinic3_rx_poll(struct hinic3_rxq *rxq, int budget) rx_cqe->status = 0; - if (num_wqe >= nic_dev->lro_replenish_thld) + if (num_wqe >= nic_dev->lro_replenish_thld) { + poll_again = true; break; + } } if (rxq->delta >= HINIC3_RX_BUFFER_WRITE) hinic3_rx_fill_buffers(rxq); - return nr_pkts; + return poll_again ? budget : nr_pkts; } -- 2.43.0 ```