[PATCH] net: macb: rate limit netdev error info print in the data path
From: Zijin Tao <hidden>
Date: 2026-09-20 10:09:55
Also in:
lkml
Subsystem:
atmel macb ethernet driver, networking drivers, the rest · Maintainers:
Théo Lebrun, Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
Now the MACB ethernet driver print the netdev error information directly by netdev_err(), which would lead to a large number of error information print if there was a significant number of error or just jumbo packets exceeding the MTU received when booting. For example, it would print a large number of: macb PHYT0036:00 eth0: not whole frame pointed by descriptor macb PHYT0036:00 eth0: not whole frame pointed by descriptor ... in gem_rx() by received a large number of packets without RX_SOF or RX_EOF flag set, especially with unknown packet type. The unlimited prints here would greatly bother and delay the system booting process unless the source stop sending packets. So rate limit the netdev error information print in the receive and transmit data path. Signed-off-by: Zijin Tao <redacted> --- drivers/net/ethernet/cadence/macb_main.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
index b8234ac4b602..c32d48d03008 100644
--- a/drivers/net/ethernet/cadence/macb_main.c
+++ b/drivers/net/ethernet/cadence/macb_main.c@@ -1617,16 +1617,16 @@ static int gem_rx(struct macb_queue *queue, struct napi_struct *napi, count++; if (!(ctrl & MACB_BIT(RX_SOF) && ctrl & MACB_BIT(RX_EOF))) { - netdev_err(bp->netdev, - "not whole frame pointed by descriptor\n"); + if (net_ratelimit()) + netdev_err(bp->netdev, "not whole frame pointed by descriptor\n"); bp->netdev->stats.rx_dropped++; queue->stats.rx_dropped++; break; } skb = queue->rx_skbuff[entry]; if (unlikely(!skb)) { - netdev_err(bp->netdev, - "inconsistent Rx descriptor chain\n"); + if (net_ratelimit()) + netdev_err(bp->netdev, "inconsistent Rx descriptor chain\n"); bp->netdev->stats.rx_dropped++; queue->stats.rx_dropped++; break;
@@ -1829,7 +1829,8 @@ static int macb_rx(struct macb_queue *queue, struct napi_struct *napi, unsigned long flags; u32 ctrl; - netdev_err(bp->netdev, "RX queue corruption: reset it\n"); + if (net_ratelimit()) + netdev_err(bp->netdev, "RX queue corruption: reset it\n"); spin_lock_irqsave(&bp->lock, flags);
@@ -2102,7 +2103,8 @@ static int macb_interrupt_misc(struct macb_queue *queue, u32 status) if (status & MACB_BIT(HRESP)) { queue_work(system_bh_wq, &bp->hresp_err_bh_work); - netdev_err(netdev, "DMA bus error: HRESP not OK\n"); + if (net_ratelimit()) + netdev_err(netdev, "DMA bus error: HRESP not OK\n"); macb_queue_isr_clear(bp, queue, MACB_BIT(HRESP)); }
@@ -2511,7 +2513,8 @@ static netdev_tx_t macb_start_xmit(struct sk_buff *skb, else hdrlen = skb_tcp_all_headers(skb); if (skb_headlen(skb) < hdrlen) { - netdev_err(bp->netdev, "Error - LSO headers fragmented!!!\n"); + if (net_ratelimit()) + netdev_err(bp->netdev, "Error - LSO headers fragmented!!!\n"); /* if this is required, would need to copy to single buffer */ return NETDEV_TX_BUSY; }
--
2.34.1