# Re: \[PATCH net-next 2/6\] psp: don't report the main netdevice's ifindex to associated namespaces

- From: Jakub Kicinski \<kuba@kernel.org\>
- Date: 2026-09-15 16:17:03 
- List: netdev
- Page: https://ratatoskr.run/netdev/2026/09/17580861
- Thread: https://ratatoskr.run/netdev/2026/09/17567415/t.md

```text
On Tue, 15 Sep 2026 06:04:23 +0000 netdev-bot+sashiko@kernel.org wrote:
> >  	if (nla_put_u32(rsp, PSP_A_DEV_ID, psd->id) ||
> > -	    nla_put_u32(rsp, PSP_A_DEV_IFINDEX, psd->main_netdev->ifindex) ||
> >  	    nla_put_u32(rsp, PSP_A_DEV_PSP_VERSIONS_CAP, psd->caps->versions) ||
> >  	    nla_put_u32(rsp, PSP_A_DEV_PSP_VERSIONS_ENA, psd->config.versions))
> >  		goto err_cancel_msg;
> >  
> >  	if (cur_net == dev_net(psd->main_netdev)) {
> > -		/* Primary device - dump assoc list */
> > +		/* Primary device - report the netdev, dump assoc list. */
> > +		if (nla_put_u32(rsp, PSP_A_DEV_IFINDEX,
> > +				psd->main_netdev->ifindex))
> > +			goto err_cancel_msg;
> > +  
> 
> [Severity: Medium]
> Should this carry a Fixes: tag?
> 
> The unconditional PSP_A_DEV_IFINDEX in psp_nl_dev_fill() has been in the
> dev-get reply, the dump entries and the dev add/change/del notifications
> since 06c2dce2d0f69 ("psp: add new netlink cmd for dev-assoc and
> dev-disassoc"), which was based on v7.1-rc7 and therefore shipped in the
> released v7.2.  The tree here is v7.3.0-rc2.

Since user space won't be able to depend on it 100% of the time 
and has to explicitly ignore the main ifindex from containers - 
my conclusion was that there's not much gain from treating it as a fix.
```
