[PATCH] net: ipconfig: use ifreq field aliases

Subsystems: networking [general], networking [ipv4/ipv6], the rest

COLD40d

3 messages, 3 authors, 2026-09-10 · open the first message on its own page

[PATCH] net: ipconfig: use ifreq field aliases

From: Lalit Shankar Chowdhury <hidden>
Date: 2026-09-09 14:45:49

Use the ifr_addr and ifr_name macros instead of the lengthier versions.

Signed-off-by: Lalit Shankar Chowdhury <redacted>
---
 net/ipv4/ipconfig.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c
index 155db067eaec..475393a86c91 100644
--- a/net/ipv4/ipconfig.c
+++ b/net/ipv4/ipconfig.c
@@ -367,11 +367,11 @@ set_sockaddr(struct sockaddr_in *sin, __be32 addr, __be16 port)
 static int __init ic_setup_if(void)
 {
 	struct ifreq ir;
-	struct sockaddr_in *sin = (void *) &ir.ifr_ifru.ifru_addr;
+	struct sockaddr_in *sin = (void *) &ir.ifr_addr;
 	int err;
 
 	memset(&ir, 0, sizeof(ir));
-	strcpy(ir.ifr_ifrn.ifrn_name, ic_dev->dev->name);
+	strcpy(ir.ifr_name, ic_dev->dev->name);
 	set_sockaddr(sin, ic_myaddr, 0);
 	if ((err = devinet_ioctl(&init_net, SIOCSIFADDR, &ir)) < 0) {
 		pr_err("IP-Config: Unable to set interface address (%d)\n",
-- 
2.53.0

Re: [PATCH] net: ipconfig: use ifreq field aliases

From: Ido Schimmel <idosch@nvidia.com>
Date: 2026-09-10 10:32:02

On Wed, Sep 09, 2026 at 02:44:16PM +0000, Lalit Shankar Chowdhury wrote:
Use the ifr_addr and ifr_name macros instead of the lengthier versions.
Please read the following document before submitting more networking
patches:

https://docs.kernel.org/next/process/maintainer-netdev.html

In particular:

https://docs.kernel.org/next/process/maintainer-netdev.html#clean-up-patches

Thanks

Re: [PATCH] net: ipconfig: use ifreq field aliases

From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2026-09-10 18:20:05

On Wed,  9 Sep 2026 14:44:16 +0000
Lalit Shankar Chowdhury [off-list ref] wrote:
Use the ifr_addr and ifr_name macros instead of the lengthier versions.

Signed-off-by: Lalit Shankar Chowdhury <redacted>
---
Why? seems like useless churn. Those header files never change
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help