[PATCH net] octeontx2-pf: fix null RX segment address free
From: <hidden>
Date: 2026-09-03 14:35:34
Also in:
lkml
Subsystem:
marvell octeontx2 physical function driver, networking drivers, the rest · Maintainers:
Sunil Goutham, Geetha sowjanya, Ratheesh Kannoth, Subbaraya Sundeep, Bharat Bhushan, Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
From: Geetha sowjanya <gakula@marvell.com>
Avoid freeing RX segment addresses when the segment address is null.
This prevents passing an invalid pointer to aura_freeptr().
Fixes: b1bc8457e9d0 ("octeontx2-pf: Cleanup all receive buffers in SG descriptor")
Signed-off-by: Nitin Shetty J <redacted>
Signed-off-by: Geetha sowjanya <gakula@marvell.com>
---
drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c
index 8d2d607bc92f..a9aefd14ae52 100644
--- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c@@ -256,9 +256,12 @@ static void otx2_free_rcv_seg(struct otx2_nic *pfvf, struct nix_cqe_rx_s *cqe, while (start < end) { sg = (struct nix_rx_sg_s *)start; seg_addr = &sg->seg_addr; - for (seg = 0; seg < sg->segs; seg++, seg_addr++) + for (seg = 0; seg < sg->segs; seg++, seg_addr++) { + if (unlikely(!*seg_addr)) + return; pfvf->hw_ops->aura_freeptr(pfvf, qidx, *seg_addr & ~0x07ULL); + } start += sizeof(*sg); } }
--
2.48.1