# Re: \[PATCH net 6/6\] net: stmmac: selftests: Don't test flow control for small rx fifos

- From: Andrew Lunn \<andrew@lunn.ch\>
- Date: 2026-08-26 18:28:43 
- List: netdev
- Page: https://ratatoskr.run/netdev/2026/08/17466183
- Thread: https://ratatoskr.run/netdev/2026/08/17464948/t.md

```text
On Wed, Aug 26, 2026 at 04:04:58PM +0200, Maxime Chevallier wrote:
> On dwmac1000, dwmac4 and dwxgmac, we only emit pause frames if there's
> at least 4096 bytes in each queue's fifo.
> 
> The phylink mac capabilities are still MAC_ASYM_PAUSE | MAC_SYM_PAUSE as
> otherwise we won't be able to negotiate 'rx on' pause. ASYM only will
> prevent negotiating 'rx off tx on', while SYM only doesn't really
> matche the reality (not symmetric if we can only do RX pause).
> 
> Fixes: 091810dbded9 ("net: stmmac: Introduce selftests support")
> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
```