# Re: \[PATCH net\] 8139cp: fix Rx and Tx not being disabled in cp\_suspend

- From: Andrew Lunn \<andrew@lunn.ch\>
- Date: 2026-08-17 15:11:47 
- List: netdev
- Page: https://ratatoskr.run/netdev/2026/08/17424363
- Thread: https://ratatoskr.run/netdev/2026/08/17419763/t.md

```text
On Mon, Aug 17, 2026 at 06:30:57AM +0200, Karl Mehltretter wrote:
> On QEMU rtl8139 model, frames that arrive while the interface is
> suspended still end up in the stack after resume. With pm_test=devices,
> which keeps devices suspended for 5s, 200 frames sent to interface
> during that time and 50 frames after resume, eth0 reports 113
> received frames.
> 
> cp_suspend() is supposed to stop receiver and the transmitter, but
> the mask is wrong: (~RxOn | ~TxOn) is ~0, nothing is cleared and Cmd
> still reads 0x0d when cp_suspend() returns.
> 
> Use ~(RxOn | TxOn) so both bits are actually cleared.
> 
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Karl Mehltretter <redacted>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
```