[PATCHv2 net-next] net: dsa: qca8k: fall back to ethernet-ports node name for LEDs

Subsystems: networking drivers, networking [dsa], the rest

3 messages, 3 authors, 2026-07-03 · open the first message on its own page

[PATCHv2 net-next] net: dsa: qca8k: fall back to ethernet-ports node name for LEDs

From: Rosen Penev <hidden>
Date: 2026-06-30 01:51:39

The device tree binding allows both "ports" and "ethernet-ports" as
the container node name.  Try "ethernet-ports" when "ports" is absent
so that newer DTBs with the preferred name work.

This matches the handling already present in qca8k-8xxx.c

Assisted-by: opencode:big-pickle
Signed-off-by: Rosen Penev <redacted>
---
 v2: resend
 drivers/net/dsa/qca/qca8k-leds.c | 3 +++
 1 file changed, 3 insertions(+)
diff --git a/drivers/net/dsa/qca/qca8k-leds.c b/drivers/net/dsa/qca/qca8k-leds.c
index ef496e345a4e..0ada28377f46 100644
--- a/drivers/net/dsa/qca/qca8k-leds.c
+++ b/drivers/net/dsa/qca/qca8k-leds.c
@@ -457,6 +457,9 @@ qca8k_setup_led_ctrl(struct qca8k_priv *priv)
 	int ret;

 	ports = device_get_named_child_node(priv->dev, "ports");
+	if (!ports)
+		ports = device_get_named_child_node(priv->dev, "ethernet-ports");
+
 	if (!ports) {
 		dev_info(priv->dev, "No ports node specified in device tree!");
 		return 0;
--
2.54.0

Re: [PATCHv2 net-next] net: dsa: qca8k: fall back to ethernet-ports node name for LEDs

From: Andrew Lunn <andrew@lunn.ch>
Date: 2026-07-02 20:43:11

On Mon, Jun 29, 2026 at 06:51:37PM -0700, Rosen Penev wrote:
The device tree binding allows both "ports" and "ethernet-ports" as
the container node name.  Try "ethernet-ports" when "ports" is absent
so that newer DTBs with the preferred name work.

This matches the handling already present in qca8k-8xxx.c

Assisted-by: opencode:big-pickle
Signed-off-by: Rosen Penev <redacted>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

Re: [PATCHv2 net-next] net: dsa: qca8k: fall back to ethernet-ports node name for LEDs

From: Paolo Abeni <pabeni@redhat.com>
Date: 2026-07-03 06:15:02

On 6/30/26 3:51 AM, Rosen Penev wrote:
The device tree binding allows both "ports" and "ethernet-ports" as
the container node name.  Try "ethernet-ports" when "ports" is absent
so that newer DTBs with the preferred name work.

This matches the handling already present in qca8k-8xxx.c

Assisted-by: opencode:big-pickle
Signed-off-by: Rosen Penev <redacted>
Apparently the PW bot is still enjoying some PTO...

Applied, thanks!

/P
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help