On 4/30/2026 6:05 PM, Jakub Kicinski wrote:

Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.


On Wed, 29 Apr 2026 08:28:19 +0000 Nikhil P. Rao wrote:

quoted

+#define PDS_CORE_FW_COMPONENT_LIST_LEN       ((PDS_PAGE_SIZE - \
+             sizeof(struct pds_core_component_list_info)) / \
+             sizeof(struct pds_core_fw_component_info))
+
+#if defined(__has_attribute) && !__has_attribute(__counted_by__)
+#define __counted_by(member)
+#endif

Please don't redefined kernel-level primitives.
It's a huge pain in the rear to deal with when indexing the code.

This patch also adds a bunch of kdoc warnings.

Last but not least Sashiko points out a number of bugs

Thanks for the review.

We will fix the issues above in v2 and also use Sashiko to review v2 and 
future patches before submission.

Nikhil