# RE: \[net-next\] net: txgbe: fix phylink leak on AML init failure

- From: Jiawen Wu \<jiawenwu@trustnetic.com\>
- Date: 2026-05-25 01:42:55 
- List: netdev
- Page: https://ratatoskr.run/netdev/2026/05/17025237
- Thread: https://ratatoskr.run/netdev/2026/05/17018073/t.md

```text
On Fri, May 22, 2026 3:08 PM, Chenguang Zhao wrote:
> Destroy the phylink instance when fixed-link setup fails.
> 
> Signed-off-by: Chenguang Zhao <redacted>
> ---
>  drivers/net/ethernet/wangxun/txgbe/txgbe_aml.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_aml.c b/drivers/net/ethernet/wangxun/txgbe/txgbe_aml.c
> index f0514251d4f3..8e301e7d1148 100644
> --- a/drivers/net/ethernet/wangxun/txgbe/txgbe_aml.c
> +++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_aml.c
> @@ -521,6 +521,7 @@ int txgbe_phylink_init_aml(struct txgbe *txgbe)
>  	err = phylink_set_fixed_link(phylink, &state);
>  	if (err) {
>  		wx_err(wx, "Failed to set fixed link\n");
> +		phylink_destroy(phylink);
>  		return err;
>  	}
> 

Reviewed-by: Jiawen Wu <jiawenwu@trustnetic.com>

Thanks!
 

```