Thread (25 messages) 25 messages, 4 authors, 7d ago

Re: [PATCH net 1/8] ice: fix UAF/NULL deref when VSI rebuild and XDP attach race

From: Jakub Kicinski <kuba@kernel.org>
Date: 2026-05-21 15:37:22

On Wed, 20 May 2026 11:34:49 -0700 Tony Nguyen wrote:
+	if (test_bit(ICE_VSI_REBUILD_PENDING, vsi->state)) {
+		if (prog) {
+			NL_SET_ERR_MSG_MOD(extack, "VSI rebuild is pending");
+			return -EAGAIN;
+		}
I seem to recall complaining about this sort of error handling to you
folks in the past. Chances are user space will just fail seeing this
error, rather than retrying. The correct behavior would be to wait.
Is that not possible?

(I think Sashiko is brewing a lot of comments for this series so it
won't make today's PR either way :()
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help