RE: [PATCH v2 net-next 13/14] net: dsa: netc: initialize buffer bool table and implement flow-control
From: Wei Fang <wei.fang@nxp.com>
Date: 2026-03-23 10:21:19
Also in:
imx, linux-arm-kernel, linux-devicetree, linuxppc-dev, lkml
On Mon, Mar 23, 2026 at 02:07:51PM +0800, Wei Fang wrote:quoted
@@ -1288,7 +1411,17 @@ static void netc_mac_link_up(structphylink_config *config,quoted
netc_port_set_rmii_mii_mac(np, speed, duplex); } + if (duplex == DUPLEX_HALF) { + /* As per 802.3 annex 31B, PAUSE frames are only supported + * when the link is configured for full duplex operation. + */ + tx_pause = false; + rx_pause = false; + }I keep seeing this totally unnecessary code in reviews of mac_link_up() methods. See phylink_resolve_an_pause().
I will remove it, thanks.