# Re: \[PATCH\] net: xgbe: use device\_get\_mac\_addr

- From: Jakub Kicinski \<kuba@kernel.org\>
- Date: 2026-03-07 00:59:45 
- List: netdev
- Page: https://ratatoskr.run/netdev/2026/03/3445746
- Thread: https://ratatoskr.run/netdev/2026/03/3439147/t.md

```text
On Tue,  3 Mar 2026 20:22:40 -0800 Rosen Penev wrote:
> -	ret = device_property_read_u8_array(dev, XGBE_MAC_ADDR_PROPERTY,
> -					    pdata->mac_addr,
> -					    sizeof(pdata->mac_addr));
> -	if (ret || !is_valid_ether_addr(pdata->mac_addr)) {
> +	ret = device_get_mac_address(dev, pdata->mac_addr);
> +	if (ret) {
>  		dev_err(dev, "invalid %s property\n", XGBE_MAC_ADDR_PROPERTY);

Feels a little odd to still use XGBE_MAC_ADDR_PROPERTY in the error
message when now we support any property name for MAC address.
Let's rewrite the error to "invalid MAC address property\n"
and delete  XGBE_MAC_ADDR_PROPERTY 
-- 
pw-bot: cr
```
