# Re: \[PATCH net-next v8 11/16\] netkit: Implement rtnl\_link\_ops-\>alloc and ndo\_queue\_create

- From: David Wei \<hidden\>
- Date: 2026-02-01 22:27:54 
- List: netdev
- Page: https://ratatoskr.run/netdev/2026/02/7942316
- Thread: https://ratatoskr.run/netdev/2026/01/7942161/t.md

```text
On 2026-02-01 09:19, Jakub Kicinski wrote:
> On Thu, 29 Jan 2026 23:28:25 +0100 Daniel Borkmann wrote:
>> +	if (netif_running(dev))
>> +		netif_carrier_off(dev);
>> +	err = netif_set_real_num_rx_queues(dev, rxq_count_new);
>> +	if (netif_running(dev))
>> +		netif_carrier_on(dev);
>
> Why do we need to flap the carrier?
> (If there's a reason perhaps add a comment?)

I saw veth doing this in veth_set_channels(): off, set num rx queues,
then on. But it doesn't sound like there's actually a need? I'll test
without this and remove it if everything works.
```