# Re: \[PATCH net v1\] net: defer \_\_dev\_set\_promiscuity() to avoid sleeping in atomic context

- From: Jakub Kicinski \<kuba@kernel.org\>
- Date: 2026-02-19 01:40:27 
- List: netdev
- Page: https://ratatoskr.run/netdev/2026/02/3418569
- Thread: https://ratatoskr.run/netdev/2026/02/3413894/t.md

```text
On Tue, 17 Feb 2026 17:10:36 -0800 Stanislav Fomichev wrote:
> > Reproducer:
> > 
> >   ip link add dummy0 type dummy
> >   ip link add team0 type team
> >   ip link set dummy0 master team0
> >   ip link set team0 up
> >   ip link add bridge0 type bridge vlan_filtering 1
> >   ip link set bridge0 up
> >   ip link set team0 master bridge0
> >   ip link add macsec0 link bridge0 type macsec
> >   ip link set macsec0 up   # triggers the bug  
> 
> Can you add it as a selftest under selftests/drivers/net/team/?

Stan, this "fix" may work for the promisc flag but won't we have 
the same problem with sync'ing the address list? Looks like team
will do:
 - team_set_rx_mode()
   - dev_uc_sync_multiple()
     - __dev_set_rx_mode(port->dev)
so AFAICT we're calling ndo_set_rx_mode without holding the instance
lock?
```
