# Re: \[PATCH net-next\] net: ntb\_netdev: Fix NULL check ordering in TX handler

- From: Jakub Kicinski \<kuba@kernel.org\>
- Date: 2026-02-26 03:22:12 
- List: netdev
- Page: https://ratatoskr.run/netdev/2026/02/11348681
- Thread: https://ratatoskr.run/netdev/2026/02/11348476/t.md

```text
On Tue, 24 Feb 2026 05:04:47 -0800 Alok Tiwari wrote:
> ntb_netdev_tx_handler() calls netdev_priv(ndev) before checking
> whether ndev is NULL. Although qp_data is expected to always be
> valid in normal operation,

Right. Can we delete the seemingly pointless null check instead?
Defensive programming is discouraged in the kernel..

> dereferencing the pointer before the
> NULL check is logically incorrect.

If you strongly prefer to keep the patch as is maybe say "valid 
but surprising" rather than "logically incorrect"

> Move netdev_priv() after validating ndev.
> 
> No functional change intended.
-- 
pw-bot: cr
```
