[PATCH 17/62] bnxt_en: Make bnxt_resume() easier to analyze

Subsystems: broadcom bnxt_en 50 gigabit ethernet driver, networking drivers, the rest

STALE195d

4 messages, 3 authors, 2026-02-23 · open the first message on its own page

[PATCH 17/62] bnxt_en: Make bnxt_resume() easier to analyze

From: Bart Van Assche <bvanassche@acm.org>
Date: 2026-02-23 21:50:27

Pass the same argument to netdev_lock() and netdev_unlock(). This patch
prepares for enabling the Clang thread-safety analysis functionality. No
functional change intended.

Cc: Shantiprasad Shettar <redacted>
Cc: netdev@vger.kernel.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index e062d5d400da..950708575268 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -17121,7 +17121,7 @@ static int bnxt_resume(struct device *device)
 	}
 
 resume_exit:
-	netdev_unlock(bp->dev);
+	netdev_unlock(dev);
 	bnxt_ulp_start(bp, rc);
 	if (!rc)
 		bnxt_reenable_sriov(bp);

Re: [PATCH 17/62] bnxt_en: Make bnxt_resume() easier to analyze

From: Jakub Kicinski <kuba@kernel.org>
Date: 2026-02-23 22:23:45

On Mon, 23 Feb 2026 13:49:05 -0800 Bart Van Assche wrote:
Pass the same argument to netdev_lock() and netdev_unlock(). This patch
prepares for enabling the Clang thread-safety analysis functionality. No
functional change intended.
Please split out the 13(?) netdev patches to a separate series.
If you CC us on a subset of the series out CI will not test it.
Please keep in mind that we ask to wait at least 24h between
resubmissions
-- 
pw-bot: cr

Re: [PATCH 17/62] bnxt_en: Make bnxt_resume() easier to analyze

From: Jakub Kicinski <kuba@kernel.org>
Date: 2026-02-23 22:24:49

On Mon, 23 Feb 2026 14:23:44 -0800 Jakub Kicinski wrote:
On Mon, 23 Feb 2026 13:49:05 -0800 Bart Van Assche wrote:
quoted
Pass the same argument to netdev_lock() and netdev_unlock(). This patch
prepares for enabling the Clang thread-safety analysis functionality. No
functional change intended.  
Please split out the 13(?) netdev patches to a separate series.
If you CC us on a subset of the series out CI will not test it.
Please keep in mind that we ask to wait at least 24h between
resubmissions
Oh, not 13, 5, you already spammed us 3 times with this. Sigh.

Re: [PATCH 17/62] bnxt_en: Make bnxt_resume() easier to analyze

From: Bart Van Assche <hidden>
Date: 2026-02-23 22:30:30

On 2/23/26 2:24 PM, Jakub Kicinski wrote:
Oh, not 13, 5, you already spammed us 3 times with this. Sigh.
Sorry for the spam. I have not yet found an SMTP server that can post
the entire patch series without reporting an error message halfway.

smtpauth.mailroute.net reported "quota exceeded" while
smtp.migadu.com reported "4.7.1 Error: too many recipients from 
2a00:79e0:2e7c:8:b343:b0de:3e59:4e65".

Bart.

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help