[PATCH io_uring 1/1] io_uring/zcrx: improve types for size calculation

Subsystems: io_uring, io_uring zcrx, the rest

STALE172d

2 messages, 2 authors, 2026-02-10 · open the first message on its own page

[PATCH io_uring 1/1] io_uring/zcrx: improve types for size calculation

From: Pavel Begunkov <asml.silence@gmail.com>
Date: 2026-02-05 18:04:50

Make sure io_import_umem() promotes the type to long before calculating
the area size. While the area size is capped at 1GB by
io_validate_user_buf_range() and fits into an "int", it's still too
error prone.

Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
---
 io_uring/zcrx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/io_uring/zcrx.c b/io_uring/zcrx.c
index 8a9df72bc094..6a6e2f8d6133 100644
--- a/io_uring/zcrx.c
+++ b/io_uring/zcrx.c
@@ -205,7 +205,7 @@ static int io_import_umem(struct io_zcrx_ifq *ifq,
 		return PTR_ERR(pages);
 
 	ret = sg_alloc_table_from_pages(&mem->page_sg_table, pages, nr_pages,
-					0, nr_pages << PAGE_SHIFT,
+					0, (unsigned long)nr_pages << PAGE_SHIFT,
 					GFP_KERNEL_ACCOUNT);
 	if (ret) {
 		unpin_user_pages(pages, nr_pages);
-- 
2.52.0

Re: [PATCH io_uring 1/1] io_uring/zcrx: improve types for size calculation

From: Jens Axboe <axboe@kernel.dk>
Date: 2026-02-10 12:26:30

On Thu, 05 Feb 2026 18:04:43 +0000, Pavel Begunkov wrote:
Make sure io_import_umem() promotes the type to long before calculating
the area size. While the area size is capped at 1GB by
io_validate_user_buf_range() and fits into an "int", it's still too
error prone.
Applied, thanks!

[1/1] io_uring/zcrx: improve types for size calculation
      commit: 417d029dc412c1028bce3d4685700332c0539a95

Best regards,
-- 
Jens Axboe


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help