[PATCH net-next v2] dt-bindings: ethernet: eswin: fix yaml schema issues

Subsystems: networking drivers, open firmware and flattened device tree bindings, the rest

STALE268d REVIEWED: 1 (0M)

1 review trailer.

2 messages, 2 authors, 2025-11-06 · open the first message on its own page

[PATCH net-next v2] dt-bindings: ethernet: eswin: fix yaml schema issues

From: <hidden>
Date: 2025-11-04 07:34:13

From: Shangjuan Wei <redacted>

eswin,hsp-sp-csr attribute is one phandle with multiple arguments,
so the syntax should be in the form of:
 items:
   - items:
       - description: ...
       - description: ...
       - description: ...
       - description: ...

To align with the description of the 'eswin-sp-csr'
attribute in the mmc,usb modules, the description
of the 'eswin,hsp-sp-csr' attribute has been modified.

Fixes: 888bd0eca93c ("dt-bindings: ethernet: eswin: Document for EIC7700 SoC")
Reported-by: Rob Herring (Arm) <robh@kernel.org>
Closes: https://lore.kernel.org/all/176096011380.22917.1988679321096076522.robh@kernel.org/
Signed-off-by: Shangjuan Wei <redacted>
Reviewed-by: Krzysztof Kozlowski <redacted>

---
Changes in v2:
  - Simplified problem description
  - Add a space after the commit ID
  - Add subject prefix
  - Link to v1:
    https://lore.kernel.org/all/20251030085001.191-1-weishangjuan@eswincomputing.com/
---
 .../bindings/net/eswin,eic7700-eth.yaml       | 20 ++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/eswin,eic7700-eth.yaml b/Documentation/devicetree/bindings/net/eswin,eic7700-eth.yaml
index 9ddbfe219ae2..91e8cd1db67b 100644
--- a/Documentation/devicetree/bindings/net/eswin,eic7700-eth.yaml
+++ b/Documentation/devicetree/bindings/net/eswin,eic7700-eth.yaml
@@ -69,17 +69,19 @@ properties:
     enum: [0, 200, 600, 1200, 1600, 1800, 2000, 2200, 2400]

   eswin,hsp-sp-csr:
+    description:
+      HSP CSR is to control and get status of different high-speed peripherals
+      (such as Ethernet, USB, SATA, etc.) via register, which can tune
+      board-level's parameters of PHY, etc.
     $ref: /schemas/types.yaml#/definitions/phandle-array
     items:
-      - description: Phandle to HSP(High-Speed Peripheral) device
-      - description: Offset of phy control register for internal
-                     or external clock selection
-      - description: Offset of AXI clock controller Low-Power request
-                     register
-      - description: Offset of register controlling TX/RX clock delay
-    description: |
-      High-Speed Peripheral device needed to configure clock selection,
-      clock low-power mode and clock delay.
+      - items:
+          - description: Phandle to HSP(High-Speed Peripheral) device
+          - description: Offset of phy control register for internal
+                         or external clock selection
+          - description: Offset of AXI clock controller Low-Power request
+                         register
+          - description: Offset of register controlling TX/RX clock delay

 required:
   - compatible
--
2.17.1

Re: [PATCH net-next v2] dt-bindings: ethernet: eswin: fix yaml schema issues

From: patchwork-bot+netdevbpf@kernel.org
Date: 2025-11-06 04:10:32

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski [off-list ref]:

On Tue,  4 Nov 2025 15:33:05 +0800 you wrote:
From: Shangjuan Wei <redacted>

eswin,hsp-sp-csr attribute is one phandle with multiple arguments,
so the syntax should be in the form of:
 items:
   - items:
       - description: ...
       - description: ...
       - description: ...
       - description: ...

[...]
Here is the summary with links:
  - [net-next,v2] dt-bindings: ethernet: eswin: fix yaml schema issues
    https://git.kernel.org/netdev/net-next/c/0567c84d683d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help