# Re: \[net-next PATCH\] net: phy: as21xxx: fill in inband caps and better handle inband

- From: Christian Marangi \<ansuelsmth@gmail.com\>
- Date: 2025-10-16 15:30:27 
- List: netdev
- Page: https://ratatoskr.run/netdev/2025/10/3254367
- Thread: https://ratatoskr.run/netdev/2025/10/3254351/t.md

```text
On Thu, Oct 16, 2025 at 04:23:49PM +0100, Russell King (Oracle) wrote:
> On Thu, Oct 16, 2025 at 05:20:07PM +0200, Christian Marangi wrote:
> > +static int as21xxx_config_inband(struct phy_device *phydev,
> > +				 unsigned int modes)
> > +{
> > +	if (modes == LINK_INBAND_ENABLE)
> > +		return aeon_dpc_ra_enable(phydev);
> 
> So what happens when phylink requests inband to be disabled?
> 
> I really don't like implementations that enable something but then
> provide no way to disable it.
>

On firmware load it's disabled by default. Can phylink ask to disable
inband at runtime?

I will try to check if there is a way to disable it.

> -- 
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

-- 
	Ansuel
```
