# Re: \[PATCH net-next v3 0/2\] net: devmem: improve cpu cost of RX token management

- From: Simon Horman \<horms@kernel.org\>
- Date: 2025-09-26 15:55:06 
- List: netdev
- Page: https://ratatoskr.run/netdev/2025/09/3233158
- Thread: https://ratatoskr.run/netdev/2025/09/3233096/t.md

```text
On Fri, Sep 26, 2025 at 08:02:52AM -0700, Bobby Eshleman wrote:
> This series improves the CPU cost of RX token management by replacing
> the xarray allocator with an niov array and a uref field in niov.
> 
> Improvement is ~5% per RX user thread.
> 
> Two other approaches were tested, but with no improvement. Namely, 1)
> using a hashmap for tokens and 2) keeping an xarray of atomic counters
> but using RCU so that the hotpath could be mostly lockless. Neither of
> these approaches proved better than the simple array in terms of CPU.
> 
> Running with a NCCL workload is still TODO, but I will follow up on this
> thread with those results when done.
> 
> Signed-off-by: Bobby Eshleman <bobbyeshleman@meta.com>

Hi Bobby,

Unfortunately this patchset doesn't apply cleanly to net-next.
So you'll need to rebase and repost at some point.

-- 
pw-bot: changes-requested
```
