Re: [PATCH net-next] net: mana: Reduce waiting time if HWC not responding
From: Simon Horman <horms@kernel.org>
Date: 2025-09-12 12:28:55
Also in:
linux-hyperv, lkml
On Wed, Sep 10, 2025 at 01:57:21PM -0700, Haiyang Zhang wrote:
quoted hunk ↗ jump to hunk
From: Haiyang Zhang <haiyangz@microsoft.com> If HW Channel (HWC) is not responding, reduce the waiting time, so further steps will fail quickly. This will prevent getting stuck for a long time (30 minutes or more), for example, during unloading while HWC is not responding. Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> --- drivers/net/ethernet/microsoft/mana/hw_channel.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)diff --git a/drivers/net/ethernet/microsoft/mana/hw_channel.c b/drivers/net/ethernet/microsoft/mana/hw_channel.c index ef072e24c46d..ada6c78a2bef 100644 --- a/drivers/net/ethernet/microsoft/mana/hw_channel.c +++ b/drivers/net/ethernet/microsoft/mana/hw_channel.c@@ -881,7 +881,12 @@ int mana_hwc_send_request(struct hw_channel_context *hwc, u32 req_len, if (!wait_for_completion_timeout(&ctx->comp_event, (msecs_to_jiffies(hwc->hwc_timeout)))) { if (hwc->hwc_timeout != 0) - dev_err(hwc->dev, "HWC: Request timed out!\n"); + dev_err(hwc->dev, "HWC: Request timed out: %u ms\n", + hwc->hwc_timeout); + + /* Reduce further waiting if HWC no response */ + if (hwc->hwc_timeout > 1) + hwc->hwc_timeout = 1;
Hi, Perhaps it is already the case, but I'm wondering if the configured value of hwc_timeout should be restored at some point.
err = -ETIMEDOUT; goto out; -- 2.34.1