# Re: \[PATCH\] net: mvpp2: Fix refcount leak in mvpp2\_use\_acpi\_compat\_mode

- From: Simon Horman \<horms@kernel.org\>
- Date: 2025-09-01 15:00:13 
- List: netdev
- Page: https://ratatoskr.run/netdev/2025/09/3195338
- Thread: https://ratatoskr.run/netdev/2025/08/3193472/t.md

```text
On Sat, Aug 30, 2025 at 05:18:54PM +0800, Miaoqian Lin wrote:
> The function calls fwnode_get_named_child_node()
> to check for a "fixed-link" child.
> It did not release the reference if present, causing a refcount leak.
> 
> Fixes: dfce1bab8fdc ("net: mvpp2: enable using phylink with ACPI")
> Signed-off-by: Miaoqian Lin <redacted>

Probably this should be targeted at the net tree, like this

Subject: [PATCH net] ...

But that notwithstanding, this looks good to me.

Reviewed-by: Simon Horman <horms@kernel.org>
```