[PATCH net-next] net: phylink: remove stale an_enabled from doc

Subsystems: sff/sfp/sfp+ module support, the rest

STALE376d

3 messages, 3 authors, 2025-08-26 · open the first message on its own page

[PATCH net-next] net: phylink: remove stale an_enabled from doc

From: David Yang <mmyangfl@gmail.com>
Date: 2025-08-24 01:30:49

state->an_enabled was removed before, but is left in mac_config() doc,
so clean it.

Fixes: 4ee9b0dcf09f ("net: phylink: remove an_enabled")
Signed-off-by: David Yang <mmyangfl@gmail.com>
---
 include/linux/phylink.h | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/include/linux/phylink.h b/include/linux/phylink.h
index 30659b615fca..9af0411761d7 100644
--- a/include/linux/phylink.h
+++ b/include/linux/phylink.h
@@ -320,9 +320,8 @@ int mac_prepare(struct phylink_config *config, unsigned int mode,
  *   If in 802.3z mode, the link speed is fixed, dependent on the
  *   @state->interface. Duplex and pause modes are negotiated via
  *   the in-band configuration word. Advertised pause modes are set
- *   according to the @state->an_enabled and @state->advertising
- *   flags. Beware of MACs which only support full duplex at gigabit
- *   and higher speeds.
+ *   according to @state->advertising. Beware of MACs which only
+ *   support full duplex at gigabit and higher speeds.
  *
  *   If in Cisco SGMII mode, the link speed and duplex mode are passed
  *   in the serial bitstream 16-bit configuration word, and the MAC
@@ -331,7 +330,7 @@ int mac_prepare(struct phylink_config *config, unsigned int mode,
  *   responsible for reading the configuration word and configuring
  *   itself accordingly.
  *
- *   Valid state members: interface, an_enabled, pause, advertising.
+ *   Valid state members: interface, pause, advertising.
  *
  * Implementations are expected to update the MAC to reflect the
  * requested settings - i.o.w., if nothing has changed between two
-- 
2.50.1

Re: [PATCH net-next] net: phylink: remove stale an_enabled from doc

From: "Russell King (Oracle)" <linux@armlinux.org.uk>
Date: 2025-08-24 08:43:19

On Sun, Aug 24, 2025 at 09:30:03AM +0800, David Yang wrote:
state->an_enabled was removed before, but is left in mac_config() doc,
so clean it.

Fixes: 4ee9b0dcf09f ("net: phylink: remove an_enabled")
Signed-off-by: David Yang <mmyangfl@gmail.com>
Reviewed-by: Russell King (Oracle) <redacted>

Thanks!

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

Re: [PATCH net-next] net: phylink: remove stale an_enabled from doc

From: patchwork-bot+netdevbpf@kernel.org
Date: 2025-08-26 01:09:58

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski [off-list ref]:

On Sun, 24 Aug 2025 09:30:03 +0800 you wrote:
state->an_enabled was removed before, but is left in mac_config() doc,
so clean it.

Fixes: 4ee9b0dcf09f ("net: phylink: remove an_enabled")
Signed-off-by: David Yang <mmyangfl@gmail.com>
---
 include/linux/phylink.h | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
Here is the summary with links:
  - [net-next] net: phylink: remove stale an_enabled from doc
    https://git.kernel.org/netdev/net-next/c/df534e757321

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help