# Re: \[PATCH net\] l2tp: do not use sock\_hold() in pppol2tp\_session\_get\_sock()

- From: Guillaume Nault \<hidden\>
- Date: 2025-08-27 12:05:42 
- List: netdev
- Page: https://ratatoskr.run/netdev/2025/08/11335498
- Thread: https://ratatoskr.run/netdev/2025/08/11335412/t.md

```text
On Tue, Aug 26, 2025 at 01:44:35PM +0000, Eric Dumazet wrote:
> pppol2tp_session_get_sock() is using RCU, it must be ready
> for sk_refcnt being zero.
> 
> Commit ee40fb2e1eb5 ("l2tp: protect sock pointer of
> struct pppol2tp_session with RCU") was correct because it
> had a call_rcu(..., pppol2tp_put_sk) which was later removed in blamed commit.

Reviewed-by: Guillaume Nault <redacted>

Thank!

```
