Thread (14 messages) 14 messages, 5 authors, 2025-07-26

Re: [PATCH] net: Revert tx queue length on partial failure in dev_qdisc_change_tx_queue_len()

From: Suchit K <hidden>
Date: 2025-07-22 16:22:00
Also in: linux-kernel-mentees, lkml

WRITE_ONCE() is missing.
Oops, I'm sorry about that.
quoted
+               while (i >= 0) {
+                       qdisc_change_tx_queue_len(dev, &dev->_tx[i]);
What happens if one of these calls fails ?

I think a fix will be more complicated...
I did consider that, but since I didn’t have a solution, I assumed it
wouldn’t fail. I also have a question. In the Qdisc_ops structure,
there’s a function pointer for change_tx_queue_len, but I was only
able to find a single implementation which is
pfifo_fast_change_tx_queue_len. Is that the only one? Apologies if
this isn’t the right place to ask such questions. I’d really
appreciate any feedback. Thank you!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help