# Re: \[PATCH net-next v2\] sfc: siena: eliminate xdp\_rxq\_info\_valid using XDP base API

- From: Edward Cree \<hidden\>
- Date: 2025-07-01 13:38:33 
- List: netdev
- Page: https://ratatoskr.run/netdev/2025/07/3115785
- Thread: https://ratatoskr.run/netdev/2025/06/3112064/t.md

```text
On 01/07/2025 14:29, Larysa Zaremba wrote:
> On Sat, Jun 28, 2025 at 01:10:33PM +0800, Fushuai Wang wrote:
>> Commit d48523cb88e0 ("sfc: Copy shared files needed for Siena (part 2)")
>> use xdp_rxq_info_valid to track failures of xdp_rxq_info_reg().
>> However, this driver-maintained state becomes redundant since the XDP
>> framework already provides xdp_rxq_info_is_reg() for checking registration
>> status.
>>
>> Signed-off-by: Fushuai Wang <redacted>
> 
> You could have sent those patches in a single patchset, but the patches 
> themselves are fine.

I asked him to split it, for a few reasons (different blamed commits,
 clearer Subject: lines, Siena is EOL).
So if you don't like it, blame me ;-)

> Reviewed-by: Larysa Zaremba <redacted>
```