# RE: \[PATCH net-next\] rtase: Refine the flexibility of Rx queue allocation

- From: Justin Lai \<justinlai0215@realtek.com\>
- Date: 2025-06-12 07:42:35 
- List: netdev
- Page: https://ratatoskr.run/netdev/2025/06/3088670
- Thread: https://ratatoskr.run/netdev/2025/06/3084784/t.md

```text
> On Tue, 10 Jun 2025 17:55:18 +0800 Justin Lai wrote:
> > Refine the flexibility of Rx queue allocation by using alloc_etherdev_mqs.
> >
> > Signed-off-by: Justin Lai <justinlai0215@realtek.com>
> > ---
> >  drivers/net/ethernet/realtek/rtase/rtase_main.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/realtek/rtase/rtase_main.c
> b/drivers/net/ethernet/realtek/rtase/rtase_main.c
> > index 4d37217e9a14..c22dd573418a 100644
> > --- a/drivers/net/ethernet/realtek/rtase/rtase_main.c
> > +++ b/drivers/net/ethernet/realtek/rtase/rtase_main.c
> > @@ -2080,8 +2080,8 @@ static int rtase_init_board(struct pci_dev *pdev,
> struct net_device **dev_out,
> >       int ret = -ENOMEM;
> >
> >       /* dev zeroed in alloc_etherdev */
> > -     dev = alloc_etherdev_mq(sizeof(struct rtase_private),
> > -                             RTASE_FUNC_TXQ_NUM);
> > +     dev = alloc_etherdev_mqs(sizeof(struct rtase_private),
> > +                              RTASE_FUNC_TXQ_NUM,
> RTASE_FUNC_RXQ_NUM);
> >       if (!dev)
> >               goto err_out;
> >
> 
> $ git grep RTASE_FUNC_.XQ_NUM
> drivers/net/ethernet/realtek/rtase/rtase.h:#define RTASE_FUNC_TXQ_NUM
> 1
> drivers/net/ethernet/realtek/rtase/rtase.h:#define RTASE_FUNC_RXQ_NUM
> 1
> 
> This patch is a nop?
> --
> pw-bot: reject

Hi Jakub,

Sorry about this, but this patch needs to be abandoned for now. It's
currently non-functional, and we'll resubmit it in the future together
with changes that support user-configurable queue numbers.
 
Thanks,
Justin
```
