# Re: \[PATCH net v3 1/2\] net: ethtool: Don't check if RSS context exists in case of context 0

- From: Edward Cree \<ecree.xilinx@gmail.com\>
- Date: 2025-06-12 09:32:16 
- List: netdev
- Page: https://ratatoskr.run/netdev/2025/06/11329286
- Thread: https://ratatoskr.run/netdev/2025/06/11329265/t.md

```text
On 12/06/2025 08:19, Gal Pressman wrote:
> Context 0 (default context) always exists, there is no need to check
> whether it exists or not when adding a flow steering rule.
> 
> The existing check fails when creating a flow steering rule for context
> 0 as it is not stored in the rss_ctx xarray.
> 
> For example:
> $ ethtool --config-ntuple eth2 flow-type tcp4 dst-ip 194.237.147.23 dst-port 19983 context 0 loc 618
> rmgr: Cannot insert RX class rule: Invalid argument
> Cannot insert classification rule
> 
> An example usecase for this could be:
> - A high-priority rule (loc 0) directing specific port traffic to
>   context 0.
> - A low-priority rule (loc 1) directing all other TCP traffic to context
>   1.
> 
> This is a user-visible regression that was caught in our testing
> environment, it was not reported by a user yet.
> 
> Fixes: de7f7582dff2 ("net: ethtool: prevent flow steering to RSS contexts which don't exist")
> Cc: Jakub Kicinski <kuba@kernel.org>
> Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
> Reviewed-by: Nimrod Oren <redacted>
> Signed-off-by: Gal Pressman <redacted>
> Reviewed-by: Joe Damato <redacted>

Reviewed-by: Edward Cree <ecree.xilinx@gmail.com>
```