# Re: \[PATCH 1/5\] dt-bindings: net: qca,ar803x: Add IPQ5018 Internal GE PHY support

- From: George Moussalem \<hidden\>
- Date: 2025-05-26 13:43:44 
- List: netdev
- Page: https://ratatoskr.run/netdev/2025/05/3069331
- Thread: https://ratatoskr.run/netdev/2025/05/3068609/t.md

```text


On 5/26/25 17:34, Andrew Lunn wrote:
>> I couldn't agree more but I just don't know what these values are exactly as
>> they aren't documented anywhere. I'm working off the downstream QCA-SSDK
>> codelinaro repo. My *best guess* for the MDAC value is that it halves the
>> amplitude and current for short cable length, but I don't know what
>> algorithm is used for error detection and correction.
>>
>> What I do know is that values must be written in a phy to phy link
>> architecture as the 'cable length' is short, a few cm at most. Without
>> setting these values, the link doesn't work.
>>
>> With the lack of proper documentation, I could move the values to the driver
>> itself and convert it to a boolean property such as qca,phy-to-phy-dac or
>> something..
>
> Making it a boolean property is good. Please include in the binding
> the behaviour when the bool is not present.

Thanks, will do.

>
> What you are really describing here is a sort cable, not phy-to-phy,
> since a PHY is always connected to another PHY. So i think the
> property name should be about the sort cable/distance.

The two common archictures across IPQ5018 boards are:
1. IPQ5018 PHY --> MDI --> RJ45 connector
2. IPQ5018 PHY --> MDI --> External PHY (ex. a PHY of a qca8337 switch)
Only in scenario 2 (phy to phy architecture), DAC values need to be set to accommodate for the short cable length. Nothing needs to be set in scenario 1 when connected directly to an RJ45 connector.

if not, qcom,phy-to-phy-dac, perhaps qcom,dac-short-cable or any other suggestions?

>
> 	Andrew

Best regards,
George

```
