# Re: \[net-next PATCH v12 1/6\] net: phy: pass PHY driver to .match\_phy\_device OP

- From: FUJITA Tomonori \<fujita.tomonori@gmail.com\>
- Date: 2025-05-19 06:09:48 
- List: netdev
- Page: https://ratatoskr.run/netdev/2025/05/3059983
- Thread: https://ratatoskr.run/netdev/2025/05/3059409/t.md

```text
On Sat, 17 May 2025 22:13:45 +0200
Christian Marangi [ref] wrote:

> Pass PHY driver pointer to .match_phy_device OP in addition to phydev.
> Having access to the PHY driver struct might be useful to check the
> PHY ID of the driver is being matched for in case the PHY ID scanned in
> the phydev is not consistent.
> 
> A scenario for this is a PHY that change PHY ID after a firmware is
> loaded, in such case, the PHY ID stored in PHY device struct is not
> valid anymore and PHY will manually scan the ID in the match_phy_device
> function.
> 
> Having the PHY driver info is also useful for those PHY driver that
> implement multiple simple .match_phy_device OP to match specific MMD PHY
> ID. With this extra info if the parsing logic is the same, the matching
> function can be generalized by using the phy_id in the PHY driver
> instead of hardcoding.
> 
> Rust wrapper callback is updated to align to the new match_phy_device
> arguments.
> 
> Suggested-by: Russell King (Oracle) <redacted>
> Reviewed-by: Russell King (Oracle) <redacted>
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> ---
>  drivers/net/phy/bcm87xx.c              |  6 ++++--
>  drivers/net/phy/icplus.c               |  6 ++++--
>  drivers/net/phy/marvell10g.c           | 12 ++++++++----
>  drivers/net/phy/micrel.c               |  6 ++++--
>  drivers/net/phy/nxp-c45-tja11xx.c      | 12 ++++++++----
>  drivers/net/phy/nxp-tja11xx.c          |  6 ++++--
>  drivers/net/phy/phy_device.c           |  2 +-
>  drivers/net/phy/realtek/realtek_main.c | 27 +++++++++++++++++---------
>  drivers/net/phy/teranetics.c           |  3 ++-
>  include/linux/phy.h                    |  3 ++-
>  rust/kernel/net/phy.rs                 |  1 +
>  11 files changed, 56 insertions(+), 28 deletions(-)

As for Rust PHY abstractions:

Reviewed-by: FUJITA Tomonori <fujita.tomonori@gmail.com>
```
